Repository navigation
Fix pending transaction Learn More link and copy - #6263
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b14ea138e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
91a94f2 to
2ba669b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2ba669b. Configure here.
2ba669b to
92877ae
Compare
The Learn More button on the send scene's pending transaction card opened a support article that no longer exists (404). Point it at the article explaining why a transaction is still pending.
The most common cause of a stuck pending transaction is a broadcast the network dropped, which only a wallet resync clears. Keep the wait or accelerate advice for a transaction the block explorer shows, and tell users to resync when it is not found, so they can self-resolve without contacting support. The swap pending transaction modal shares this text.
92877ae to
37316ad
Compare
|
Landing this without a review.
|
1 participant
Description
Asana task
The Send scene's "Pending Transaction" card (and the swap-processing modal that reuses its message) had a Learn More button pointing at a retired help-center URL that now returns 404. This points it at the current article, Why is my Transaction still Pending, in
edgeConfig,testConfig, and the fallback inSendScene2.The card's message now tells users how to resolve the state themselves, keeping the two cases apart: a transaction found in a block explorer can be waited on or accelerated, while one that is not found after a few minutes needs a wallet resync.
Eleven non-English locale files (de, es, esMX, fr, ja, kaa, ko, pt, ru, vi, zh) held an untranslated copy of the old English message, and
selectLocaleprefers any non-empty locale value over English, so those users would have kept the old text. Crowdin does not refresh such copies when the source string changes, so this PR updates them to the new English.it.jsonhas a real Italian translation and is left for Crowdin to retranslate.Blocking sends while a wallet is still syncing is separate work and not part of this PR.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Copy and external help URL changes only; no send-blocking or wallet-sync logic is modified.
Overview
Fixes the Pending Transaction warning on Send (and the modal that shares its copy) by pointing Learn More at a live support article instead of a retired URL that 404s. The default/fallback URL is updated in
edgeConfig,testConfig, andSendScene2.The pending transaction message now distinguishes two paths: if the tx shows on a block explorer, wait or accelerate; if it is missing after a few minutes, resync the wallet. That string is updated in
en_USand in locale files that still had the old English text (Italian left for Crowdin).Reviewed by Cursor Bugbot for commit 37316ad. Bugbot is set up for automated code reviews on this repo. Configure here.
Test evidence
92877aeExplain resync in pending transaction message
2026-10-20
🪓 forced setHasPendingTx(true) in updatePendingTxState on SendScene2
1. 🪓 pending tx card new copy
2. 🪓 learn more article