Skip to content

Compat for 0.24 - #57

Merged
AntonOresten merged 3 commits into
MurrellGroup:mainfrom
BenjaminDoran:compat-for-0.24
Dec 27, 2025
Merged

AntonOresten merged 3 commits into
MurrellGroup:mainfrom
BenjaminDoran:compat-for-0.24

Conversation

@BenjaminDoran

Copy link
Copy Markdown
Contributor

Just wanted to let you know that changing the signatures for these three functions fixes the tests for me, and seems to work for Makie v0.24.

It no longer works for Makie ≤v0.23, because Makie.ComputeGraph only gets defined in Makie v0.24.

Not sure how you wanted to handle backwards compatibility, so feel free take or leave this

@codecov

codecov Bot commented Dec 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.24%. Comparing base (c1f8d14) to head (c654095).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   50.24%   50.24%           
=======================================
  Files          13       13           
  Lines         601      601           
=======================================
  Hits          302      302           
  Misses        299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AntonOresten

Copy link
Copy Markdown
Member

Hi! Thanks for taking the time. I think it can work backwards if we simply remove the type from that argument altogether. Nevertheless I'll merge this.🙃

@AntonOresten
AntonOresten merged commit 96c8537 into MurrellGroup:main Dec 27, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants