Commit edd97b8
authored
CSTACKEX-321: when nothing is changed in volume resize wizard directl… (#110)
Calling resizeVolume with the existing volume size still invoked the
storage driver, causing an unnecessary driver resize request for
volumes.
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour
functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically
be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Before Patch API is still called in case of no changes in the wizard:
<img width="1423" height="1034" alt="Screenshot 2026-09-24 at 4 33
33 PM"
src="https://github.com/user-attachments/assets/5480986e-bc79-4bc7-b05c-62077c2cc93e"
/>
actually resizes (IN UI)
<img width="1441" height="638" alt="Screenshot 2026-09-24 at 4 36 00 PM"
src="https://github.com/user-attachments/assets/8430eaa3-947e-41d4-8573-518f7831d7f0"
/>
after the fix Patch api is not called :
<img width="1393" height="1035" alt="Screenshot 2026-09-24 at 4 17
52 PM"
src="https://github.com/user-attachments/assets/b53e1146-560a-437a-9b0c-501be9ec4d76"
/>
Shows success immediately:
<img width="1471" height="728" alt="Screenshot 2026-09-24 at 4 28 37 PM"
src="https://github.com/user-attachments/assets/9cdd57b0-2b1f-4550-9830-46f87c439061"
/>
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran
to -->
#### How did you try to break this feature and the system with this
change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->1 parent 1c4bbcb commit edd97b8
1 file changed
Lines changed: 5 additions & 4 deletions
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1446 | 1446 | | |
1447 | 1447 | | |
1448 | 1448 | | |
1449 | | - | |
1450 | | - | |
| 1449 | + | |
1451 | 1450 | | |
1452 | | - | |
1453 | | - | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
1454 | 1455 | | |
1455 | 1456 | | |
1456 | 1457 | | |
| |||
0 commit comments