Skip to content

[GrantFox][High] Harden market-creation validation #899

Description

@greatest0fallt1me

Summary

Harden market-creation validation

Why this matters

Invalid dates, odds, assets, or participant limits can create markets that cannot settle safely.

Scope

Centralize validation for temporal, numeric, authorization, and asset constraints.

Acceptance criteria

  • Invalid combinations are rejected before persistence.
  • Boundary timestamps and numeric limits are covered.
  • Validation rules are shared by API and worker paths.
  • Tests prove malformed input cannot bypass validation.

Validation

Add regression coverage for existing behavior, failure modes, authorization boundaries, and compatibility. The implementation must pass the repository CI checks.

Non-goals

  • Typo-only, formatting-only, or documentation-only changes.
  • Unrelated refactors or dependency upgrades.
  • Weakening existing security, authorization, CI, or production safeguards.

Contributor application

Before implementation, comment with relevant experience, a 1–4 bullet approach, and an estimate for opening the first draft PR. Wait for maintainer assignment before coding.

PR requirements

Use a feature branch, include Closes #<issue-number>, check every acceptance criterion, link criteria to code/tests, explain security and failure-mode considerations, and pass CI.

Reward-readiness

This is a substantive GrantFox campaign issue. Merge and CI success do not by themselves guarantee reward eligibility; final reward-readiness is determined by campaign review.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions