Skip to content

Commit 8761f60

Browse files
committed
refactor: record #1370 and #1366 merged
1 parent 4a1f440 commit 8761f60

7 files changed

Lines changed: 14 additions & 9 deletions

File tree

‎doc/01-summary.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ Several patterns show code that outlived its purpose:
237237
- **Parity suites** that exist only because two orchestrators exist.
238238
- **Covgap tests:** 402 tests (26.9K lines), 136 of them asserting human text.
239239
- **Exact-sentence assertions:** 328 of them. The output-polish PR touched 65 test files.
240-
- **Dead flags and vestigial abstractions:** `--vendor-source` (one valid value), `VendorSource`/`PackageSource` (one variant each), `PatchSources::mem_blobs` (never `Some`; {{C23}}), `lock_inventory/wired.rs` (no production caller), pre-v5 redirect-ledger readers.
240+
- **Dead flags and vestigial abstractions:** `--vendor-source` (one valid value), `VendorSource`/`PackageSource` (one variant each), `PatchSources::mem_blobs` (never `Some`; {{C23}}), `PnpmLock::wired_integrity` (no production caller since `lock_inventory/wired.rs` was deleted, #1370), pre-v5 redirect-ledger readers.
241241
- **History in reference docs:** 177 `v5.0` annotations in the contract.
242242
- **Very large squash merges:** +53K, +85K and +94K lines.
243243

‎doc/04-js-lockfiles.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ _Last checked against main @ 9ab72d4 on 2026-10-09 by audit-ecosystems (the E17
3333
| **bun.lockb (binary)** | `bun_lockb.rs` 1663/591; `bun_binary.rs` 664/351; `bun_workspace.rs` 184/199; `redirect/bun_binary.rs` 108/61; `upstream/bun_lockb.rs` 152/229 | **2,771** | **1,431** | 1,574 |
3434
| **vlt** | `vlt_lock.rs` 2080/2032; `vlt_lock_text.rs` 1008/1540; `npm_dir.rs` 910/319; `redirect/vlt.rs` 676/313; `vlt_heal.rs` 542/573; `vlt_preflight.rs` 233/302; `hosted/vlt.rs` 217; `upstream/vlt.rs` 328/268; inventory 165; vex 392/794 | **6,551** | **6,141** | ~9.3K (10 files + 3 shared dirs) |
3535

36-
Shared npm-family infrastructure adds `npm_common.rs` 613/832, `npm_flavor.rs` 707/1338 and about 1.8K lines in `lock_inventory/{mod,view,wired,recover,npm_family}`.
36+
Shared npm-family infrastructure adds `npm_common.rs` 613/832, `npm_flavor.rs` 707/1338 and about 1.6K lines in `lock_inventory/{mod,view,recover,npm_family}` (`wired.rs` deleted, #1370).
3737

3838
`crawlers/npm_crawler/oracle.rs` (1,846 lines) is **entirely test code**: a verbatim copy of the old crawler, kept as an equivalence oracle (`oracle.rs:1-5`). It has done its job and can be retired.
3939

‎doc/06-discovery-vex.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ Across the repo that is **eight hand-rolled XML scanners**, 4–5 independent wa
8787
- **Test RNG.** xorshift is implemented four times.
8888

8989
**Dead code:**
90-
- `lock_inventory/wired.rs` (`wired_vendor_integrity`, 221 production lines) has **no production caller** (verified); only tests use it. That matches the v5 migration note "`repair` no longer reconstructs a missing ledger from lockfiles". The module docs at `lock_inventory/mod.rs:13-15` are stale. Its only consumer, `formats::pnpm::PnpmLock::wired_integrity`, is dead with it, and it imports `vex::discover` (a `vendor` → `vex` edge). {{E41}}
90+
- `lock_inventory/wired.rs` (`wired_vendor_integrity`), which had no production caller, was deleted with its tests (#1370), and with it the `vendor` → `vex` import it carried. Its only consumer, `formats::pnpm::PnpmLock::wired_integrity`, is now dead too; it and the stale `"wired_vendor_integrity("` needle in `vex/discover/mod.rs`'s forbidden-reader guard remain. {{E41}}
9191
- `vex/discover/deno.rs` is an empty extractor, by design: its module doc keeps per-ecosystem coverage explicit. Not a defect.
9292

9393
### 6.5 VEX design
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
[agent] 2026-10-09: architecture refactor run (merge follow-up)
2+
3+
- main: `43af719`.
4+
- Merged: [#1370](https://github.com/SocketDev/socket-patch/pull/1370) (E41, the #801 slice of #782: `lock_inventory/wired.rs` deleted) and [#1366](https://github.com/SocketDev/socket-patch/pull/1366) (C30, #824 slice 3).
5+
- Register: E41 is `partly fixed (#1370)`; `PnpmLock::wired_integrity`, a `python_lock.rs` doc line and the `vex/discover/mod.rs` guard needle remain. C30 notes slice 3 merged (#1366).
6+
- Passages rewritten to match `main`: the `doc/06-discovery-vex.md` dead-code bullet ({{E41}}), the `doc/01-summary.md` dead-flags line, and the `doc/04-js-lockfiles.md` `lock_inventory` line count.
7+
- No new PR and no new claims. The next scheduled run ranks again.

‎register/10-audit-ecosystems.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ _Last updated 2026-10-09T18:56Z · main @ 9ab72d4_
4242
| E38 | 2 | The product-manifest probe table is copied three times and has drifted: `vex.rs` lacks the csproj and gemspec probes. The probes don't reuse the format parsers. | new finding; 6.5 | #816 | rejected; closed not planned 2026-10-08 (#816 fails safely) |
4343
| E39 | 3 | `canonicalize_pypi_name` lives in `crawlers/` (29 importers) and `Ecosystem` in `crawlers/types.rs`, while `LockfileEntry.ecosystem` is a string. Target: `core/src/ecosystem.rs`. | 2.1; 6.4 | #883 | rejected; closed not planned 2026-10-08 (#883: move deferred) |
4444
| E40 | 2 | `vex_consumed.rs`, in the CLI, is a third copy of package-manager layout knowledge (cargo, Maven, Go rules); its npm alias walk drifted from core on case (merged E62). | 6.5; new finding | #855, #856 | partly fixed (#1008): alias walk deleted (#856); tracking #855 |
45-
| E41 | 2 | Dead discovery code: `lock_inventory/wired.rs` has no production caller. | 6.4; 6.5; R11 | #782 | in PR #1370; #801 folded into #782 |
45+
| E41 | 2 | Dead discovery code: `lock_inventory/wired.rs` has no production caller. | 6.4; 6.5; R11 | #782 | partly fixed (#1370); `wired.rs` deleted; `PnpmLock::wired_integrity`, a `python_lock.rs` doc line and the `vex/discover/mod.rs` guard needle remain; #801 folded into #782 |
4646
| E42 | 2 | The embedded `--vex` glue is copied per command (scan, apply, and vendor ×3), each with caller-injected bypass sets. Target: one `EmbeddedVex` helper. | 6.5; R13 | #966 | decision #966; whether `--vex` stays embedded (Q2) is undecided |
4747
| E43 | 2 | Fail closed on unmodeled resolution config in one shared place. | 2.2 #3 | #458 | partly fixed (#987 and earlier); `go.work` remains (#458, E81) |
4848
| E44 | 2 | Decide: is the napi addon + in-memory engine a supported product (one pipeline), or deleted (−4.5K prod)? | §6 Q1; 3.7 #6 | #1200 | decision #1200; contract L670 (#1029) names a future GitHub App as the caller |

‎register/20-audit-core.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ _Last updated 2026-10-09T15:55Z · main @ 31383f5_
3232
| C27 | 3 | Agent mode wrote no Maven sidecars. | 7.4 | #551 | already fixed (#646) |
3333
| C28 | 3 | socket.yml builds a hand-made YAML tree to read 8 keys. | 7.5 | | rejected; the tree implements the contract's scoped YAML refusals |
3434
| C29 | 3 | The `client.rs` split (2.8K lines) into client, vendor_service and credentials; the debug-ordering machinery (`HeldBack`) has 45 call sites. | 7.2; 7.6 #8 | #913 | filed #913; #871 deferred (closed not planned) |
35-
| C30 | 2 | No shared test-support: `binary()` is defined in 103 files and `git_sha256` in 86, there are 15 `scrub_socket_env` (14 bodies), xorshift is implemented four times, and the VEX helpers are forked. | 6.4; 8.5 D | #824, #823 | filed #824, #823; #850 deleted 8 of 15 `scrub_socket_env`; #824 slices merged (#1124, #1258): `binary()` in 15 files, `git_sha256` in 26; slice 3 in PR #1366 |
35+
| C30 | 2 | No shared test-support: `binary()` is defined in 103 files and `git_sha256` in 86, there are 15 `scrub_socket_env` (14 bodies), xorshift is implemented four times, and the VEX helpers are forked. | 6.4; 8.5 D | #824, #823 | filed #824, #823; #850 deleted 8 of 15 `scrub_socket_env`; #824 slices merged (#1124, #1258): `binary()` in 15 files, `git_sha256` in 26; slice 3 merged (#1366, 5 more files) |
3636
| C31 | 3 | 240 test executables on `f3c6313` (review: 207); target ~25. Needs C10 first. | 8.5 A | | to verify; count confirmed, not filed: blocked on #794 (env-mutating `#[serial]`) |
3737
| C32 | 3 | Tracking: ~478 one-line 4+-word `.contains` sentence assertions (245 in the 27 covgap files, 26,086 lines, 391 tests on `05ecc6e`) become `--json`/`errorCode` checks plus render suites; `_json`/`_human` twins collapse. | 2.5; 8.5 G/H | #1089 | filed #1089; tracking #1089 (#1090 folded in); child 1 fixed (#1272, `tests/common/envelope.rs`) |
3838
| C33 | 3 | Tracking: `CLI_CONTRACT.md` (417 KB on `431b818`; 332 KB at review) should be a checked reference (flags, env vars, codes, exit codes) plus ≤300 lines of prose, with freshness tests. | 8.3; 8.5 F/I | #948 | filed #948; tracking #948 (#949, #678 folded in) |

‎register/90-refactor.md‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
### Refactor routine (`refactor`, hourly, highest leverage first)
2-
_Last updated 2026-10-09T21:57Z · main @ 9c00b54_
2+
_Last updated 2026-10-09T23:12Z · main @ 43af719_
33

44
**In flight:**
5-
- [#1370](https://github.com/SocketDev/socket-patch/pull/1370): #782 slice (#801 scope): dead `lock_inventory/wired.rs` (`wired_vendor_integrity`) and its tests deleted. E41. +3/−224 prod, +4/−256 tests. `state: ready`.
6-
- [#1366](https://github.com/SocketDev/socket-patch/pull/1366): #824 children 2–3 slice 3: 5 more test files use `tests/common` `binary()`/`git_sha256` (`vendor_ecosystem_fixtures` includers take `mod common`). C30. +0/−0 prod, +24/−50 tests. `state: ready`.
75
- [#1358](https://github.com/SocketDev/socket-patch/pull/1358): scala-cli Bloop evidence fails closed on an oversized, unreadable or non-Bloop project file, the sbt reader's policy; skip branches deleted. Fixes #1270 (E95). +23/−6 prod, +87/−1 tests. `state: ready`.
86
- [#1188](https://github.com/SocketDev/socket-patch/pull/1188): one `Pipfile.lock` writer (`formats::pipenv::splice_entry`). #1128 (E14). +303/−235 prod. `state: ready`.
97
- [#1126](https://github.com/SocketDev/socket-patch/pull/1126): 7 inline purl-type checks through `Ecosystem::from_purl` + guard. Issue #747 (C20, slice 1). `state: ready`.
@@ -15,7 +13,7 @@ _Last updated 2026-10-09T21:57Z · main @ 9c00b54_
1513

1614
| # | Candidate | B | U | D | R | Score | Note |
1715
|---|---|:-:|:-:|:-:|:-:|:-:|---|
18-
| 1 | #782 E41 (#801 scope): delete dead `lock_inventory/wired.rs` | 0 | 0 | ≈2.3 | L | ≈4.6 | **taken: #1370** |
16+
| 1 | #782 E41 (#801 scope): delete dead `lock_inventory/wired.rs` | 0 | 0 | ≈2.3 | L | ≈4.6 | merged (#1370) |
1917
| 2 | #931 + #998 + #1063 + #1123: one manifest load + error mapper | 4 | 1 | ≈6 | M | ≈24 | skipped: `apply.rs`, `vendor.rs`, `repair.rs` (#1049, #1273, #1345, #1357, #1369 …) |
2018
| 3 | #1365 (E96): one requirements.txt exact-pin grammar | 1 | 1 | ≈2.5 | M | ≈6 | skipped: `redirect/requirements.rs` (#1333, #1279), `vendor/pypi_requirements.rs` (#1309, #1279) |
2119
| 4 | #824 child 4: `oracle_support` and `npm_crawler/oracle` xorshift onto `test_rng::Rng` | 0 | 0 | 2 | L | 4 | free |

0 commit comments

Comments
 (0)