dynamic levels do not work unless created during serverStartedEvent

[dercodeKoenig]

tested this for hours. make a dynamic level in game and when you tp there, the entire level is broken. you can not destroy blocks, entities do not tick correctly. the world and chunks do load.

when a level is created during the serverStarted event it works all good, but dynamic level creation does not work.

[dercodeKoenig]

tested on local server and dedicated server.
creating dimension during ServerStartedEvent -> works
creating dimension after 200 server ticks -> dimension broken

[dercodeKoenig]

listening to LevelTickEvent.Post turns out, dynamic levels are not ticking. this would explain why block placement and sync and entity ticks do not work but chunks do load

[dercodeKoenig]

probable cause world array does not update:

    private int worldArrayMarker = 0;
    private int worldArrayLast = -1;
    private ServerLevel[] worldArray;
    @Deprecated //Forge Internal use Only, use to protect against concurrent modifications in the world tick loop.
    public synchronized void markWorldsDirty() {
        worldArrayMarker++;
    }
    private ServerLevel[] getWorldArray() {
        if (worldArrayMarker == worldArrayLast && worldArray != null)
            return worldArray;
        worldArray = this.levels.values().stream().toArray(x -> new ServerLevel[x]);
        worldArrayLast = worldArrayMarker;
        return worldArray;
    }


    public void tickChildren(BooleanSupplier hasTimeLeft) {
        this.getPlayerList().getPlayers().forEach(p_341570_ -> p_341570_.connection.suspendFlushing());
        this.profiler.push("commandFunctions");
        this.getFunctions().tick();
        this.profiler.popPush("levels");

        for(ServerLevel serverlevel : this.getWorldArray()) {

[dercodeKoenig]

solution: when a level is created, make sure getWorldArray() in MinecraftServer updates!!! it appears it does not do this right now.

this explains why levels added before first server tick work and not after

[dercodeKoenig]

fixed in pull request: #9