Repository navigation
fix(calls): 参加者の右クリックで通話用メニューを表示する - #59
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (1 updated, 0 added, 0 removed)
Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Calls の音声タイル・映像タイル・参加者一覧を右クリックすると、対象参加者の通話用メニューをカーソル位置に表示します。VC モデレーター指定・参加者からの削除などは既存の権限判定と操作を再利用します。
Why
参加者を右クリックしてもブラウザ標準メニューやプロフィールリンクのメニューが開き、通話用の操作にアクセスできませんでした。
Additional info (optional)
関連: #17
「…」ボタンの挙動と、メニュー表示前のメディア状態取得は維持しています。右クリックではイベントを capture 段階で受け取り、非同期の取得中もブラウザ標準メニューを抑止します。
検証:
pnpm --filter frontend test test/unit/calls-join-confirmation.test.ts test/unit/calls-session.test.ts test/unit/use-calls-room.test.ts: 81 件 PASS(音声・映像・発言者リンク・リスナーリンクから対象参加者への操作を確認)pnpm --filter frontend typecheck: PASSnode scripts/check-shipping.mjs --base origin/develop: lint / SPDX / locale safety PASS実ブラウザでの動作確認とスクリーンショット取得は未実施です。画面の見た目や文言は変更していません。
CHANGELOG はリポジトリ方針に従い未変更。候補: Calls の参加者を右クリックして通話用メニューを開けるように修正。
Checklist