Skip to content

fix(calls): 参加者の右クリックで通話用メニューを表示する - #59

Merged
mattyatea merged 2 commits into
developfrom
codex/calls-participant-context-menu
Oct 4, 2026
Merged

mattyatea merged 2 commits into
developfrom
codex/calls-participant-context-menu

Conversation

@mattyatea

@mattyatea mattyatea commented Oct 4, 2026 •

Copy link
Copy Markdown

What

Calls の音声タイル・映像タイル・参加者一覧を右クリックすると、対象参加者の通話用メニューをカーソル位置に表示します。VC モデレーター指定・参加者からの削除などは既存の権限判定と操作を再利用します。

Why

参加者を右クリックしてもブラウザ標準メニューやプロフィールリンクのメニューが開き、通話用の操作にアクセスできませんでした。

Additional info (optional)

関連: #17

「…」ボタンの挙動と、メニュー表示前のメディア状態取得は維持しています。右クリックではイベントを capture 段階で受け取り、非同期の取得中もブラウザ標準メニューを抑止します。

検証:

  • pnpm --filter frontend test test/unit/calls-join-confirmation.test.ts test/unit/calls-session.test.ts test/unit/use-calls-room.test.ts: 81 件 PASS(音声・映像・発言者リンク・リスナーリンクから対象参加者への操作を確認)
  • pnpm --filter frontend typecheck: PASS
  • node scripts/check-shipping.mjs --base origin/develop: lint / SPDX / locale safety PASS

実ブラウザでの動作確認とスクリーンショット取得は未実施です。画面の見た目や文言は変更していません。

CHANGELOG はリポジトリ方針に従い未変更。候補: Calls の参加者を右クリックして通話用メニューを開けるように修正。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copilot AI balanced review requested due to automatic review settings October 4, 2026 19:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: Type4ny-Project/Misskey/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 390832b5-9e0c-45b7-9737-be8e026d273c
📥 Commits

Reviewing files that changed from the base of the PR and between e4ac93b and 147aeeb.

📒 Files selected for processing (2)
  • packages/frontend/src/components/MkCallsRoomWindow.vue
  • packages/frontend/test/unit/calls-join-confirmation.test.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

🖥 Frontend Diagnostics Report

(No significant changes)

View details

Requests by resource type
Type Requests Encoded bytes
Base Head Δ Base Head Δ
Document 2 2 0 34 KB 34 KB 0 B
Script 151 151 0 2.4 MB 2.4 MB 0 B
Stylesheet 63 63 0 319 KB 319 KB 0 B
Fetch 28 28 0 47 KB 47 KB 0 B
Image 9 9 0 238 KB 238 KB 0 B
Font 2 2 0 129 KB 129 KB 0 B
Other 9 9 0 421 KB 421 KB $\color{orange}{\text{+8 B}}$
V8 heap snapshot statistics
Metric @ Base @ Head Δ MAD
$\color{gray}{\rule{8pt}{8pt}}$ Total 12 MB
± 3.3 KB
12 MB
± 2.7 KB
$\text{+13 KB}$
$\text{+0.1\%}$
4.2 KB
$\color{orange}{\rule{8pt}{8pt}}$ Code 2.9 MB 3 MB $\text{+6 KB}$ 2 KB
$\color{red}{\rule{8pt}{8pt}}$ Strings 1.3 MB 1.3 MB $\text{+56 B}$ 346 B
$\color{cyan}{\rule{8pt}{8pt}}$ JS arrays 121 KB 121 KB 0 B 0 B
$\color{green}{\rule{8pt}{8pt}}$ Typed arrays 0 B 0 B 0 B 0 B
$\color{yellow}{\rule{8pt}{8pt}}$ System objects 0 B 0 B 0 B 0 B
$\color{violet}{\rule{8pt}{8pt}}$ Other JS objs 2.1 MB 2.1 MB $\text{+580 B}$ 267 B
$\color{pink}{\rule{8pt}{8pt}}$ Other non-JS objs 5.4 MB 5.4 MB $\text{+4.7 KB}$ 4.2 KB

Download representative heap snapshot: base / head

📦 Bundle Stats

Chunk size diff (1 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 6.1 MB 6.1 MB $\text{+447 B}$ $\text{+0\%}$
src/components/MkCallsRoomWindow.vue ja-JP/haphjDVoN-BfV2_wxN.js → ja-JP/haphjDVoN-CMuQjo_t.js
23 KB 23 KB $\text{+447 B}$ $\color{orange}{\text{+1.9\%}}$
(other generated chunks) 2.3 MB 2.3 MB 0 B 0%
Startup chunk size (0 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 934 KB 934 KB 0 B 0%
(other generated chunks) 860 KB 860 KB 0 B 0%
(other) 74 KB 74 KB 0 B 0%

Startup chunks are the Vite entry for src/_boot_.ts and its static imports.

Bundles Modules Entries Imports Size
Static Dynamic Rendered Gzip Brotli
Base 506 3,004 22 11,213 364 11 MB 3 MB 2.6 MB
Head 506 3,004 22 11,213 364 11 MB 3 MB 2.6 MB
Δ 0 0 0 0 0 $\text{+868 B}$ $\text{+115 B}$ $\text{+92 B}$
Δ (%) 0% 0% 0% 0% 0% $\text{+0\%}$ $\text{+0\%}$ $\text{+0\%}$

Open treemap HTML

@mattyatea
mattyatea merged commit ae89203 into develop Oct 4, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants