Skip to content

fix(calls): 退出確認前に通話パネルを折りたたむ - #70

Merged
mattyatea merged 1 commit into
developfrom
codex/fix-calls-leave-confirmation
Oct 5, 2026
Merged

mattyatea merged 1 commit into
developfrom
codex/fix-calls-leave-confirmation

Conversation

@mattyatea

Copy link
Copy Markdown

What

退出ボタンを押した時点で通話パネルを折りたたみ、確認ダイアログがパネルに隠れないようにします。キャンセル時は通話を継続し、パネルを再び開けます。

Why

展開した通話パネルが退出確認に重なり、確認ボタンを操作できないという報告への対応です。

Additional info (optional)

関連: #17

  • PASS: vitest --run --globals --config vitest.config.unit.ts test/unit/calls-dock.test.ts(6件)。確認待ちの折りたたみ、キャンセル後の再展開、承認後の退出を検証。
  • PASS: 変更した2ファイルへの eslint --quiet、node scripts/check-shipping.mjs --base origin/develop(lint / SPDX / locale safety)。
  • 実ブラウザでの表示確認・全体ビルドは未実施。テスト起動時にローカルサーバー未起動による接続エラーが出ますが、テストは全件成功しています。
  • CHANGELOGは未編集。候補: 通話パネルが退出確認に重なり、操作できなくなる問題を修正。
  • AI(Codex)による実装・PR作成。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copilot AI balanced review requested due to automatic review settings October 5, 2026 08:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Type4ny-Project/Misskey/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ed0ae757-8c41-4a78-9de7-0b0aedc90b4a
📥 Commits

Reviewing files that changed from the base of the PR and between 2bb19b9 and a4499bb.

📒 Files selected for processing (2)
  • packages/frontend/src/ui/_common_/CallsDock.vue
  • packages/frontend/test/unit/calls-dock.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

退出確認ダイアログを表示する前に、CallsDockを折りたたむよう変更しました。確認をキャンセルした場合の状態と、退出が実行されないことをユニットテストで検証します。

Changes

CallsDockの退出確認

Layer / File(s) Summary
確認前の折りたたみと確認結果の検証
packages/frontend/src/ui/_common_/CallsDock.vue, packages/frontend/test/unit/calls-dock.test.ts
leaveRoomは確認ダイアログの前にドックを折りたたみます。テストは確認待ちの間に退出処理が実行されないこと、キャンセル後にドックを再展開できること、確認が承認された場合に退出が一度実行されることを検証します。

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a4499

The dock folds before confirmation, remains reopenable after cancellation, and exits only after confirmation. No actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 通話パネルを退出確認前に折りたたむ変更を具体的に示しています。
Description check ✅ Passed 「What」「Why」「Additional info」「Checklist」の各項目があり、変更内容、目的、テスト結果、未実施項目を記載しています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

確認の前に、ドックはすっと閉じます
返事を待つ間、退出はまだです
キャンセルなら、また開けます
承認されたら、退出へ進みます
テストが動きを確かめます

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

🖥 Frontend Diagnostics Report

(No significant changes)

View details

Requests by resource type
Type Requests Encoded bytes
Base Head Δ Base Head Δ
Document 2 2 0 34 KB 34 KB 0 B
Script 151 151 0 2.4 MB 2.4 MB $\color{green}{\text{-2 B}}$
Stylesheet 63 63 0 319 KB 319 KB 0 B
Fetch 28 28 0 47 KB 47 KB 0 B
Image 9 9 0 238 KB 238 KB 0 B
Font 2 2 0 129 KB 129 KB 0 B
Other 9 9 0 421 KB 421 KB $\color{green}{\text{-1 B}}$
V8 heap snapshot statistics
Metric @ Base @ Head Δ MAD
$\color{gray}{\rule{8pt}{8pt}}$ Total 12 MB
± 3.8 KB
12 MB
± 4.2 KB
$\text{-9.5 KB}$
$\text{-0.1\%}$
5.7 KB
$\color{orange}{\rule{8pt}{8pt}}$ Code 2.9 MB 2.9 MB $\text{-2.1 KB}$ 2.8 KB
$\color{red}{\rule{8pt}{8pt}}$ Strings 1.3 MB 1.3 MB $\text{-12 B}$ 201 B
$\color{cyan}{\rule{8pt}{8pt}}$ JS arrays 121 KB 121 KB $\text{-36 B}$ 0 B
$\color{green}{\rule{8pt}{8pt}}$ Typed arrays 0 B 0 B 0 B 0 B
$\color{yellow}{\rule{8pt}{8pt}}$ System objects 0 B 0 B 0 B 0 B
$\color{violet}{\rule{8pt}{8pt}}$ Other JS objs 2.1 MB 2.1 MB 0 B 267 B
$\color{pink}{\rule{8pt}{8pt}}$ Other non-JS objs 5.4 MB 5.4 MB $\text{-5.1 KB}$ 4.3 KB

Download representative heap snapshot: base / head

📦 Bundle Stats

Chunk size diff (1 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 6.1 MB 6.1 MB $\text{-2 B}$ $\text{-0\%}$
(other generated chunks) 2.3 MB 2.3 MB 0 B 0%
(other) 15 KB 14 KB $\text{-2 B}$ $\text{-0\%}$
Startup chunk size (0 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 935 KB 935 KB 0 B 0%
(other generated chunks) 861 KB 861 KB 0 B 0%
(other) 74 KB 74 KB 0 B 0%

Startup chunks are the Vite entry for src/_boot_.ts and its static imports.

Bundles Modules Entries Imports Size
Static Dynamic Rendered Gzip Brotli
Base 506 3,004 22 11,213 364 11 MB 3 MB 2.6 MB
Head 506 3,004 22 11,213 364 11 MB 3 MB 2.6 MB
Δ 0 0 0 0 0 0 B $\text{-4 B}$ $\text{+21 B}$
Δ (%) 0% 0% 0% 0% 0% 0% $\text{-0\%}$ $\text{+0\%}$

Open treemap HTML

@mattyatea
mattyatea merged commit 397246f into develop Oct 5, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants