Repository navigation
fix(calls): 退出確認前に通話パネルを折りたたむ - #70
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough退出確認ダイアログを表示する前に、CallsDockを折りたたむよう変更しました。確認をキャンセルした場合の状態と、退出が実行されないことをユニットテストで検証します。 ChangesCallsDockの退出確認
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The dock folds before confirmation, remains reopenable after cancellation, and exits only after confirmation. No actionable merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 確認の前に、ドックはすっと閉じます Comment |
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (1 updated, 0 added, 0 removed)
Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
What
退出ボタンを押した時点で通話パネルを折りたたみ、確認ダイアログがパネルに隠れないようにします。キャンセル時は通話を継続し、パネルを再び開けます。
Why
展開した通話パネルが退出確認に重なり、確認ボタンを操作できないという報告への対応です。
Additional info (optional)
関連: #17
vitest --run --globals --config vitest.config.unit.ts test/unit/calls-dock.test.ts(6件)。確認待ちの折りたたみ、キャンセル後の再展開、承認後の退出を検証。eslint --quiet、node scripts/check-shipping.mjs --base origin/develop(lint / SPDX / locale safety)。Checklist