Skip to content

Commit fbddce4

Browse files
shinseongsuok2c
authored andcommitted
Use PrefixedIncrementingId for BasicHttpClientConnectionManager id
1 parent fd25e8e commit fbddce4

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import java.util.concurrent.ExecutionException;
3434
import java.util.concurrent.TimeoutException;
3535
import java.util.concurrent.atomic.AtomicBoolean;
36-
import java.util.concurrent.atomic.AtomicLong;
3736
import java.util.concurrent.atomic.AtomicReference;
3837
import java.util.concurrent.locks.ReentrantLock;
3938

@@ -46,6 +45,7 @@
4645
import org.apache.hc.client5.http.impl.ConnPoolSupport;
4746
import org.apache.hc.client5.http.impl.ConnectionHolder;
4847
import org.apache.hc.client5.http.impl.ConnectionShutdownException;
48+
import org.apache.hc.client5.http.impl.PrefixedIncrementingId;
4949
import org.apache.hc.client5.http.io.ConnectionEndpoint;
5050
import org.apache.hc.client5.http.io.HttpClientConnectionManager;
5151
import org.apache.hc.client5.http.io.HttpClientConnectionOperator;
@@ -100,7 +100,7 @@ public class BasicHttpClientConnectionManager implements HttpClientConnectionMan
100100

101101
private static final Logger LOG = LoggerFactory.getLogger(BasicHttpClientConnectionManager.class);
102102

103-
private static final AtomicLong COUNT = new AtomicLong(0);
103+
private static final PrefixedIncrementingId INCREMENTING_ID = new PrefixedIncrementingId("ep-");
104104

105105
private final HttpClientConnectionOperator connectionOperator;
106106
private final HttpConnectionFactory<ManagedHttpClientConnection> connFactory;
@@ -130,7 +130,7 @@ public BasicHttpClientConnectionManager(
130130
super();
131131
this.connectionOperator = Args.notNull(httpClientConnectionOperator, "Connection operator");
132132
this.connFactory = connFactory != null ? connFactory : ManagedHttpClientConnectionFactory.INSTANCE;
133-
this.id = String.format("ep-%010d", COUNT.getAndIncrement());
133+
this.id = INCREMENTING_ID.getNextId();
134134
this.expiry = Long.MAX_VALUE;
135135
this.socketConfig = SocketConfig.DEFAULT;
136136
this.connectionConfig = ConnectionConfig.DEFAULT;

0 commit comments

Comments
 (0)