Repository navigation
fix: preserve declared YAML scalar types - #78
Conversation
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@LouisDeconinck Would you be so kind to fix the tests so that I can proceed with the merge? |
|
The |
|
@LouisDeconinck Thank you ❤️ There's clearly still a bug with the tests (42mn+ to run) but I'll address in a dedicated PR |
What this PR does:
Prevents YAML scalar type inference from replacing explicitly declared AsyncAPI property types before deserialization. This allows unquoted specification/API versions and numeric MQTT QoS values to be read through the document reader.
Adds a focused regression test covering
asyncapi: 3.0.0,info.version: 1.0.0, andbindings.mqtt.qos: 2.Fixes #76
Additional information:
dotnet build --no-restorepasses.