feat(help): show open/closed status in thread title (#55)

* feat(help): show open/closed status in thread title

Discord doesn't let bots control the display order of a forum post's
applied tags, so the open/closed tag routinely collapses into "+N" on
post cards. Mirror the status in the thread title with an emoji prefix
(green open / red closed), which is always visible.

The title is set before archiving/locking because renaming a thread
unarchives it, which would otherwise reopen a just-closed post.

Reverts the applied-tag reordering from #52 (and its src/lib/discord/
tags.ts helper, removed separately) since Discord ignores applied_tags
order for card display, so that approach had no effect.

* refactor(help): remove orderAppliedTags helper

Unused after reverting the applied-tag reordering from #52.

* feat(help): sync title status on manual tag changes

Update the thread title emoji when an admin flips the open/closed tag
via Edit Tags, handled in the existing ThreadUpdate reconciler. No-op
when the title already matches, so it won't rename (and reopen) a thread
closed via /close.

Author: phorcys420

src/commands/util/close.ts

@@ -6,7 +6,7 @@ import {
   isHelpPost,
 } from "@lib/discord/channels.js";
 import { getCommandMention } from "@lib/discord/commands.js";
-import { orderAppliedTags } from "@lib/discord/tags.js";
+import { applyStatusToTitle } from "@lib/discord/status.js";
 
 import {
   type ThreadChannel,
@@ -44,15 +44,23 @@ export async function handleIssueState(
 
   const { tagToAdd, tagToRemove } = getTagsForCloseState(close);
 
+  const postTags = threadChannel.appliedTags;
+
   try {
-    // Add the target state tag, drop its opposite, and reorder so status
-    // tags follow the channel's configured order (open/closed first).
-    const nextTags = orderAppliedTags(threadChannel, [
-      ...threadChannel.appliedTags.filter((t) => t !== tagToRemove),
-      tagToAdd,
-    ]);
-
-    await threadChannel.setAppliedTags(nextTags, "Thread lifecycle");
+    // Update tags
+    if (!postTags.includes(tagToAdd)) {
+      postTags.push(tagToAdd);
+    }
+
+    if (postTags.includes(tagToRemove)) {
+      postTags.splice(postTags.indexOf(tagToRemove), 1);
+    }
+
+    await threadChannel.setAppliedTags(postTags, "Thread lifecycle");
+
+    // Surface the status in the title so it is always visible regardless of
+    // tag order. Renaming unarchives a thread, so do this before archiving.
+    await applyStatusToTitle(threadChannel, close);
 
     const reopenHint =
       close && !lock

src/events/channels.ts

@@ -2,7 +2,7 @@ import { config } from "../lib/config.js";
 import { getTagsForCloseState } from "../commands/util/close.js";
 import { isHelpPost } from "../lib/discord/channels.js";
 import { applyWaitingTag } from "../lib/discord/help.js";
-import { orderAppliedTags } from "../lib/discord/tags.js";
+import { applyStatusToTitle } from "../lib/discord/status.js";
 
 import { debounce } from "throttle-debounce";
 
@@ -36,12 +36,14 @@ const handleEvent = debounce(
           const { tagToRemove } = getTagsForCloseState(isClose);
           if (newThread.appliedTags.includes(tagToRemove)) {
             await newThread.setAppliedTags(
-              orderAppliedTags(
-                newThread,
-                newThread.appliedTags.filter((t) => t !== tagToRemove),
-              ),
+              newThread.appliedTags.filter((t) => t !== tagToRemove),
             );
           }
+
+          // Keep the title status in sync when an admin flips the status tag
+          // manually. This is a no-op when the title already matches (e.g. the
+          // change came from /close), so it won't rename an archived thread.
+          await applyStatusToTitle(newThread, isClose);
         }
       }
     }
@@ -60,9 +62,7 @@ const handleEvent = debounce(
           const isClose = tag === config.helpChannel.closedTag;
           const { tagToRemove } = getTagsForCloseState(isClose);
           if (!newThread.appliedTags.includes(tagToRemove)) {
-            await newThread.setAppliedTags(
-              orderAppliedTags(newThread, [...newThread.appliedTags, tag]),
-            );
+            await newThread.setAppliedTags([...newThread.appliedTags, tag]);
           }
         }
       }
@@ -76,7 +76,9 @@ export default function registerEvents(client: Client) {
       return;
     }
 
-    // A new help post is waiting for the Coder team to respond.
+    // A new help post is open and waiting for the Coder team to respond.
+    // Set the title status before anything archives the thread.
+    await applyStatusToTitle(thread, false);
     await applyWaitingTag(thread, false);
   });
 

src/lib/discord/help.ts

@@ -1,5 +1,4 @@
 import { config } from "@lib/config.js";
-import { orderAppliedTags } from "@lib/discord/tags.js";
 import { isTeamMember } from "@lib/discord/users.js";
 
 import {
@@ -42,12 +41,11 @@ export async function applyWaitingTag(
   if (alreadyCorrect) return;
 
   // Forum posts allow at most 5 tags. Keep the desired tag and drop the
-  // opposite one, ordering by the channel's tag configuration and trimming
-  // any overflow from the lowest-priority tags.
-  const nextTags = orderAppliedTags(thread, [
+  // opposite one, trimming any overflow from the least recent tags.
+  const nextTags = [
     desired,
     ...thread.appliedTags.filter((t) => t !== desired && t !== opposite),
-  ]).slice(0, 5);
+  ].slice(0, 5);
 
   await thread.setAppliedTags(nextTags, "Help post waiting state");
 }

src/lib/discord/status.ts

@@ -0,0 +1,37 @@
+import { type ThreadChannel } from "discord.js";
+
+// Discord does not let bots control the display order of a forum post's
+// applied tags, so the open/closed tag often collapses into "+N". A title
+// prefix is always visible, so we mirror the status there too.
+export const OPEN_PREFIX = "\uD83D\uDFE2";
+export const CLOSED_PREFIX = "\uD83D\uDD34";
+
+const MAX_THREAD_NAME_LENGTH = 100;
+const STATUS_PREFIXES = [OPEN_PREFIX, CLOSED_PREFIX];
+
+// Removes any leading status prefix (and following whitespace) from a name.
+function stripStatusPrefix(name: string): string {
+  let base = name.trimStart();
+  for (const prefix of STATUS_PREFIXES) {
+    if (base.startsWith(prefix)) {
+      base = base.slice(prefix.length).trimStart();
+    }
+  }
+  return base;
+}
+
+// Prefixes the thread title with the status emoji, replacing any existing one.
+// Discord unarchives a thread when it is renamed, so callers must apply the
+// status BEFORE archiving or locking, otherwise the post reopens.
+export async function applyStatusToTitle(
+  thread: ThreadChannel,
+  closed: boolean,
+): Promise<void> {
+  const prefix = closed ? CLOSED_PREFIX : OPEN_PREFIX;
+  const base = stripStatusPrefix(thread.name);
+  const maxBaseLength = MAX_THREAD_NAME_LENGTH - prefix.length - 1;
+  const nextName = `${prefix} ${base.slice(0, maxBaseLength)}`;
+
+  if (thread.name === nextName) return;
+  await thread.setName(nextName);
+}