Incorrect types are causing errors when using TypeScript with moduleResolution set to node16 or nodenext #1146

Activity

1. wojtekmaj

   added a commit that references this issue on Jul 12, 2023

   Add TypeScript config that checks module resolution

   ...

   243c566
2. MatanBobi

   transferred this issue fromtesting-library/react-testing-libraryon Jul 17, 2023
3. k2snowman69 commented on Aug 6, 2023

   

   k2snowman69

   on Aug 6, 2023

   More actions

   Just spreading awareness, typescript-eslint has dropped node10 support meaning anyone using typescript-eslint@6 or above (which only supports node16 and above module resolution) and @testing-library/user-event (which only supports node10 resolution due to this bug) are incompatible with one another.

   @wojtekmaj FYI there seems to be a bug in the typescript playground (not the link you sent but the playground itself) preventing your reproduction from loading correctly. Some additional steps:

   1. Go to link
   2. Open the tsconfig editor
   3. Change the following settings
      1. target=ES2022
      2. module=Node16
   4. Close the tsconfig editor

   You should now see the error originally mentioned
4. kentcdodds commented on Aug 8, 2023

   

   kentcdodds

   on Aug 8, 2023

   Member

   More actions

   For anyone looking for a workaround until this is fixed, you can add this to the top of your test file:

   import userEventDefault from '@testing-library/user-event'
   
   // https://github.com/testing-library/user-event/issues/1146
   const userEvent =
   	userEventDefault as unknown as (typeof userEventDefault)['default']
   
   const user = userEvent.setup() // <-- types!

   👍React with 👍6Reacted by Wojciech Maj, Richard, Obie Munoz, Paul Shryock, Stephanie Andrews and Alex Ryltsov
5. k2snowman69 commented on Aug 8, 2023

   

   k2snowman69

   on Aug 8, 2023

   More actions

   This workaround worked unblocked me and it should be forward compatible whenever it gets fixed.

   import UserEventModule from "@testing-library/user-event";
   
   const userEvent = UserEventModule.default ?? UserEventModule;
   

   👍React with 👍1Reacted by Alex Ryltsov
6. kentcdodds

   added a commit that references this issue on Sep 14, 2023

   fix(exports): add a named export for userEvent

   ...

   4019cee
7. kentcdodds commented on Sep 14, 2023

   

   kentcdodds

   on Sep 14, 2023

   Member

   More actions

   I just pushed and published a quick fix in @testing-library/user-event@14.5.0. So now you can use a named import:

   import { userEvent } from '@testing-library/user-event'

   And this won't have the same problems.

   We keep the default export for backward compatibility and there's still a bit of an issue with the types masquerading as ESM, but at least this should unblock most folks.

   Unfortunately I don't have any more time to improve things more officially.

   👍React with 👍3Reacted by silverwind, Corban Riley and fregante

   ❤️React with ❤️7Reacted by henry, Wojciech Maj, Paul Shryock, Oussama MESSAOUDI, Dustin Ruetz, fregante and victoria-fedev
8. sysmat commented on Sep 15, 2023

   

   sysmat

   on Sep 15, 2023

   More actions

   • I use 14.5.0 and import { userEvent } from '@testing-library/user-event'; and getting error:

   ./node_modules/@testing-library/user-event/dist/esm/_interop/dtl.js:3:61-73 - Error: export 'default' (imported as 'def__default') was not found in '@testing-library/dom'
   

   👍React with 👍5Reacted by Michaël Perrin, kle-pra, Yann Braga, Lucas Curti and Joshua Unrau
9. michaelperrin commented on Sep 15, 2023

   

   michaelperrin

   on Sep 15, 2023

   More actions

   I have the same error as @sysmat when running StoryBook with version 14.5.0 of the @testing-library/user-event library. I will try to provide more details about that issue.
10. yannbf commented on Sep 15, 2023

    

    yannbf

    on Sep 15, 2023

    Last edited by yannbf

    Contributor

    More actions

    Hey @kentcdodds as others have stated, this release ended up having unfortunate side effects.

    I created an issue with reproduction steps here: #1160

    @michaelperrin (and any other Storybook users): I just released v0.2.1 with a temporary fix for this issue.
11. bradleyayers

    added 4 commits that reference this issue on Jan 29, 2024

    Update @testing-library/user-event to fix :check

    ...

    91182f5

    Update @testing-library/user-event to fix :check

    ...

    10cb0a2

    Update @testing-library/user-event to fix :check

    ...

    1af0e07

    Update @testing-library/user-event to fix :check

    ...

    4d943d0
12. djalmaaraujo commented on Apr 3, 2024

    

    djalmaaraujo

    on Apr 3, 2024

    More actions

    I still can't make it work using 14.5.0. Anyone?
13. ryaa commented on Apr 5, 2024

    

    ryaa

    on Apr 5, 2024

    More actions

    I still can't make it work using 14.5.0. Anyone?

    This workaround worked for me #1146 (comment)
14. CrispyBaguette

    added a commit that references this issue on Nov 8, 2024

    Update dependency @testing-library/user-event to v14.5.2 (#47)

    ...

    49110c8