diff --git a/static/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.stories.tsx b/static/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.stories.tsx index f37345763441..8bcc54c7bb9f 100644 --- a/static/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.stories.tsx +++ b/static/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.stories.tsx @@ -8,6 +8,7 @@ import {parseAsString, useQueryState} from 'nuqs'; import {Button} from '@sentry/scraps/button'; import {CodeBlock} from '@sentry/scraps/codeBlock'; import {ExternalLink} from '@sentry/scraps/link'; +import {Heading} from '@sentry/scraps/text'; import type {AnnotationItem} from 'sentry/components/charts/annotations/types'; import {ConfigStore} from 'sentry/stores/configStore'; @@ -58,6 +59,25 @@ const sampleDurationTimeSeriesP75: TimeSeries = { }), }; +const sampleDurationTimeSeriesP90: TimeSeries = { + ...sampleDurationTimeSeries, + yAxis: 'p90(span.duration)', + values: sampleDurationTimeSeries.values.map(datum => { + return {...datum, value: datum.value ? datum.value * 0.7 + 30 * Math.random() : null}; + }), +}; + +const sampleDurationTimeSeriesP95: TimeSeries = { + ...sampleDurationTimeSeries, + yAxis: 'p95(span.duration)', + values: sampleDurationTimeSeries.values.map(datum => { + return { + ...datum, + value: datum.value ? datum.value * 0.85 + 30 * Math.random() : null, + }; + }), +}; + const shiftedSpanSamples = shiftTabularDataToNow(spanSamplesWithDurations); const releases = [ @@ -836,26 +856,32 @@ export default Storybook.story('TimeSeriesWidgetVisualization', story => { }); story('Low Confidence Data', () => { - const createLowConfidenceTimeSeriesClone = function ( - timeSeries: TimeSeries - ): TimeSeries { - return { - ...timeSeries, - values: timeSeries.values.map((value, index) => { - if ((index > 10 && index < 16) || (index > 30 && index < 33)) { - return {...value, confidence: 'low'}; - } - return value; - }), - }; - }; + const lowConfidenceDuration = withLowConfidenceIntervals(sampleDurationTimeSeries, [ + [20, 25], + ]); + + const twoIntervals: LowConfidenceInterval[] = [ + [10, 15], + [30, 33], + ]; + const twoIntervalsDurations = [ + sampleDurationTimeSeries, + sampleDurationTimeSeriesP95, + sampleDurationTimeSeriesP90, + sampleDurationTimeSeriesP75, + sampleDurationTimeSeriesP50, + ].map(timeSeries => withLowConfidenceIntervals(timeSeries, twoIntervals)); - const lowConfidenceDurationTimeSeries = createLowConfidenceTimeSeriesClone( - sampleDurationTimeSeries - ); - const lowConfidenceDurationP50TimeSeries = createLowConfidenceTimeSeriesClone( - sampleDurationTimeSeriesP50 - ); + const fiveIntervals: LowConfidenceInterval[] = [ + [3, 5], + [10, 12], + [18, 22], + [28, 30], + [38, 41], + ]; + + // 47 of 49 points, just over 95% of the chart + const mostlyLowConfidence: LowConfidenceInterval[] = [[2, 48]]; return ( @@ -866,32 +892,79 @@ export default Storybook.story('TimeSeriesWidgetVisualization', story => {

- - + + Single series, one low-confidence interval + + + + + + + + + + + + + + + Five series, two low-confidence intervals + + + new Line(timeSeries))} /> - - + + new Area(timeSeries))} /> - - + + new Bars(timeSeries, {stack: 'all'}) + )} /> - - + + + + + Multiple lines, five low-confidence intervals + + + + new Line(withLowConfidenceIntervals(timeSeries, fiveIntervals)) + )} + /> + + + + Multiple bars, more than 95% low confidence + + + + new Bars(withLowConfidenceIntervals(timeSeries, mostlyLowConfidence), { + stack: 'all', + }) + )} + /> +
); @@ -1416,6 +1489,12 @@ const MediumWidget = styled('div')` height: 250px; `; +const GridWidget = styled('div')` + position: relative; + min-width: 0; + height: 250px; +`; + const SmallWidget = styled('div')` position: relative; width: 360px; @@ -1533,6 +1612,25 @@ const X_AXIS_TICK_TEST_CASES: Array<{endMs: number; label: string; startMs: numb }, ]; +/** + * Inclusive start and end indexes of a run of low-confidence data points. + */ +type LowConfidenceInterval = [start: number, end: number]; + +function withLowConfidenceIntervals( + timeSeries: TimeSeries, + intervals: LowConfidenceInterval[] +): TimeSeries { + return { + ...timeSeries, + values: timeSeries.values.map((value, index) => + intervals.some(([start, end]) => index >= start && index <= end) + ? {...value, confidence: 'low'} + : value + ), + }; +} + function WithTimeSeriesConfidenceFeature({children}: {children: ReactNode}) { const organization = useOrganization();