Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: export types from toplevel - #748

Closed
forivall wants to merge 1 commit into
googleapis:mainfrom
forivall:export-types
Closed

forivall wants to merge 1 commit into
googleapis:mainfrom
forivall:export-types

Conversation

@forivall

Copy link
Copy Markdown

While #411 is marked as closed, it's still bad practice to perform deep imports, and so I'm opening this PR to export the types at the top level.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed) N/A
  • Appropriate docs were updated (if necessary) N/A

Fixes #411 🦕

@forivall
forivall requested review from a team and daniel-sanche July 22, 2024 19:39
@google-cla

google-cla Bot commented Jul 22, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Jul 22, 2024
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Jul 22, 2024
@product-auto-label product-auto-label Bot added the stale: old Pull request is old and needs attention. label Aug 22, 2024
@product-auto-label product-auto-label Bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Sep 21, 2024
@forivall

forivall commented Feb 4, 2026

Copy link
Copy Markdown
Author

I'd still love to see this get merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging-bunyan API. size: xs Pull request size is extra small. stale: extraold Pull request is critically old and needs prioritization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export types

3 participants