Repository navigation
fix(pipelines): align incremental-pipeline.py with canonical RAG v4 schema and ingestion - #306
Open
ABHISHEKUPAI wants to merge 1 commit into
Open
ABHISHEKUPAI wants to merge 1 commit into
ABHISHEKUPAI wants to merge 1 commit into
Conversation
…schema and ingestion Signed-off-by: ABHISHEKUPAI <abhishekupai6055@gmail.com>
google-oss-prow
Bot
requested review from
franciscojavierarceo and
tarekabouzeid
November 20, 2026 13:41
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #305
This PR ports the incremental documentation ingestion pipeline (
incremental-pipeline.py) to the canonical RAG Architecture v4 (milvus_store.pyandcanonical_rag_ingest.py).Following the initial RAG v4 hybrid migration (#249),
kubeflow-pipeline.pywas switched to Lean Schema v4 with native Milvus BM25, Hugo-aware parsing, and structured metadata. However,incremental-pipeline.pywas left on the legacy v2 architecture:file_unique_idwithoutdocument_id,sparse_vector,release_date,doc_type, orsection_path, which fails or corrupts the productionkubeflow_docsv4 collection.file_unique_id == ..., which does not exist in Schema v4.RecursiveCharacterTextSplitter, bypassing canonical Hugo block parsing.Changes Made
docs-agent-mcp/pipelines/incremental-pipeline.py):RecursiveCharacterTextSplitterwithmilvus_store.chunk_github_jsonl(...)andmilvus_store.embed_chunk_records(...).chunk_size=1200,chunk_overlap=100) to token-based (target_tokens=DEFAULT_TARGET_TOKENS,overlap_tokens=DEFAULT_OVERLAP_TOKENS) frommilvus_store.delete_old_vectors&store_milvus_incremental):delete_old_vectorstoMilvusClientand updated the deletion filter todocument_id in [...](usingrepo_name:file_path).store_milvus_incrementalto delegate directly tomilvus_store.store_embedded_records(..., clean_rebuild=False), which provides native document-level replacement and BM25 indexing.docs-agent-mcp/pipelines/README.md):tests/test_incremental_pipeline.py):download_specific_files.delete_old_vectorsquerying bydocument_id in [...]viaMilvusClient.delete_old_vectors.chunk_and_embed_incrementalgenerating valid Schema v4 records with titles and section paths.chunk_and_embed_incremental.store_milvus_incrementaldelegating tostore_embedded_records(clean_rebuild=False).store_milvus_incrementalcleanly skipping empty input files.Verification