Commit d2d1074
cards demo share: iOS lit the card black; Safari's bars; white flash on dark systems (#1017)
## What changed
Three fixes for the cards share page, found after #1016 went live.
- The card rendered nearly black on iOS. The studio environment maps
were `Float32` `DataTexture`s, and iOS Safari has no
`OES_texture_float_linear`, so the PMREM could not filter them and
sampled black; the card was lit by the one directional lamp alone. The
maps are now uploaded as half floats (`DataUtils.toHalfFloat`), which
every WebGL2 implementation filters. The desktop picture is unchanged.
- Grey bands above and below the page. Mobile Safari colors its status
bar and tab bar from the document background, which was the app body's
surface (`#1a1a1a` in dark) rather than the page's (`#111111`). The
share page's `html` and `body` now take its surface, and the page
exports its own `themeColor` (the root layout's `theme-color` metas
moved to a `viewport` export so the page-level one replaces them).
- White flash on a dark system (desktop). The page's surface and ink
were inline styles from a React state that started light and flipped in
an effect after hydration. They are now CSS custom properties keyed on
`html[data-theme]`, which the root layout's boot script sets before the
first paint, so the server's HTML paints in the right colors. The GL
reads the theme through `useSyncExternalStore` (client snapshot during
hydration, re-rendered before paint), and follows a theme switch.
## Test plan
- iOS 27 Simulator (iPhone 18 Pro), Safari, against the local dev
server: the green Buchi card is lit and legible in dark mode; status and
tab bar areas sample as the page color in both light (`#f8f8f7`) and
dark (`#111111`).
- Desktop Chromium: the playground stage in light and dark looks as
before the half-float change.
- CDP screencast of the page load in headless Chromium with
`colorScheme: dark`: production shows a light frame before hydration;
the branch shows only dark frames. SSR HTML carries no inline surface
style.
- `curl` of `/` and `/c/{slug}` shows the app's and the page's
`theme-color` tags respectively, no duplicates.
---------
Co-authored-by: Cursor <cursoragent@cursor.com>1 parent 8029cf9 commit d2d1074
6 files changed
Lines changed: 77 additions & 32 deletions
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
5 | 11 | | |
6 | 12 | | |
7 | 13 | | |
| |||
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
32 | 43 | | |
33 | 44 | | |
34 | 45 | | |
| |||
Lines changed: 19 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
106 | 109 | | |
107 | 110 | | |
108 | 111 | | |
| |||
201 | 204 | | |
202 | 205 | | |
203 | 206 | | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | 207 | | |
210 | 208 | | |
211 | 209 | | |
| |||
217 | 215 | | |
218 | 216 | | |
219 | 217 | | |
220 | | - | |
221 | 218 | | |
222 | 219 | | |
223 | 220 | | |
| |||
313 | 310 | | |
314 | 311 | | |
315 | 312 | | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
316 | 323 | | |
317 | 324 | | |
318 | 325 | | |
| |||
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
29 | 38 | | |
30 | 39 | | |
31 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
11 | 20 | | |
12 | 21 | | |
13 | 22 | | |
| |||
35 | 44 | | |
36 | 45 | | |
37 | 46 | | |
38 | | - | |
39 | | - | |
40 | 47 | | |
41 | 48 | | |
42 | 49 | | |
| |||
Lines changed: 19 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
60 | 77 | | |
61 | 78 | | |
62 | 79 | | |
| |||
121 | 138 | | |
122 | 139 | | |
123 | 140 | | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
| 141 | + | |
132 | 142 | | |
133 | 143 | | |
134 | 144 | | |
| |||
240 | 250 | | |
241 | 251 | | |
242 | 252 | | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
| 253 | + | |
251 | 254 | | |
252 | 255 | | |
253 | 256 | | |
| |||
0 commit comments