Skip to content

SqlQuery.execute() and StatementPreparer.execute() have incorrect documentation #70

Description

@richard-shurtz

SqlQuery.execute() indicates @return whether the query succeeded in its execution
And
StatementPrepared.execute() indicates return if the query succeeded or not
But the underlying jdbc documentation indicates true if the first result is a ResultSet object; false if it is an update count or there are no results [https://docs.oracle.com/javase/7/docs/api/java/sql/Statement.html#execute(java.lang.String)]

In practice, any INSERT statement executed with .execute() returns false, which the Relate documentation would have you believe indicates that the query failed somehow.

We should update the documentation to match the jdbc documentation

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions