[kakkokari-gtyih]

What

プライバシー設定が検索候補から消える問題を修正

Why

<template #label><SearchLabel>{{ setting.label }}</SearchLabel></template>
<template #caption><SearchText>{{ setting.caption }}</SearchText></template>

この形は想定されていない

Additional info (optional)

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md
• (If possible) Add tests

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: misskey-dev/misskey
• Branch: develop
• File: .coderabbit.yaml
• Commit: d9b1fc5
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 94c7fb6a-57ec-431f-b9c3-6ca9662895bf

Commits

Reviewing files that changed from the base of the PR and between d9b1fc5 and 324ffcc.

Files ignored due to path filters: 1

• CHANGELOG.md is excluded by !CHANGELOG.md

Files selected for processing: 1

• packages/frontend/src/pages/settings/privacy.vue

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

フォロー承認設定の検索対象に、ローカル・リモート設定のラベルと説明文を追加しました。選択項目のラベルとキャプションから検索用ラッパーを削除しました。

Changes: プライバシー設定の検索

Layer / File(s)	Summary
表示内容と検索キーワード packages/frontend/src/pages/settings/privacy.vue	フォロー承認設定の検索キーワードに、ローカル・リモート設定のラベルと説明文を追加しました。選択項目のラベルとキャプションから SearchLabel と SearchText を削除しました。

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

• misskey-dev/misskey#18053: 同じファイルで、フォロー承認設定の検索キーワードとテンプレート上の検索用ラッパーを変更しています。

Suggested reviewers: samunohito

Merge Risk: Minimal · up to 324ff

This change is limited to privacy-setting search keywords and search wrappers; no merge-blocking risk remains.

Pre-merge checks: 5

Check name	Status	Explanation
Description check		説明にはWhatとWhyが記載され、変更内容と原因が明確です。ローカルテストとテスト追加は未実施ですが、必須情報は概ね記載されています。
Title check		タイトルは、プライバシー設定が検索候補から消える問題を修正する変更内容を明確に示しています。
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/frontend/src/pages/settings/privacy.vue

Parsing error: Unexpected token {

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{設定の言葉が検索に並びます
ローカルの説明も加わります
リモートの説明も加わります
ラベルのラッパーを外します
検索の道しるべが整います}

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.81%. Comparing base (77c719e) to head (324ffcc).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #18058       +/-   ##
============================================
- Coverage    26.90%   12.81%   -14.10%     
============================================
  Files         1162      227      -935     
  Lines        39921    11129    -28792     
  Branches     10994     3689     -7305     
============================================
- Hits         10742     1426     -9316     
+ Misses       23410     7625    -15785     
+ Partials      5769     2078     -3691     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🖥 Frontend Diagnostics Report

Metric	@ Base	@ Head	Δ	MAD
Requests	248 ± 0	249 ± 0	$\color{orange}{\text{+1}}$ $\color{orange}{\text{+0.4\%}}$	0
Console errors	3 ± 0	4 ± 0	$\color{orange}{\text{+1}}$ $\color{orange}{\text{+33.3\%}}$	0

Only metrics showing significant changes are displayed.

View details

Requests by resource type

Type	Requests			Encoded bytes
	Base	Head	Δ	Base	Head	Δ
Document	2	2	0	33 KB	33 KB	0 B
Script	148	148	0	2.1 MB	2.1 MB	0 B
Stylesheet	58	58	0	284 KB	284 KB	0 B
Fetch	20	20	0	46 KB	46 KB	0 B
Image	9	10	$\color{orange}{\text{+1}}$	254 KB	254 KB	0 B
Font	2	2	0	118 KB	118 KB	0 B
Other	9	9	0	421 KB	421 KB	$\color{green}{\text{-5 B}}$

V8 heap snapshot statistics

Metric	@ Base	@ Head	Δ	MAD
$\color{gray}{\rule{8pt}{8pt}}$ Total	11 MB ± 4.9 KB	11 MB ± 38 KB	$\text{+96 KB}$ $\text{+0.9\%}$	38 KB
$\color{orange}{\rule{8pt}{8pt}}$ Code	2.8 MB	2.8 MB	$\text{+17 KB}$	414 B
$\color{red}{\rule{8pt}{8pt}}$ Strings	1.3 MB	1.3 MB	$\text{+528 B}$	197 B
$\color{cyan}{\rule{8pt}{8pt}}$ JS arrays	112 KB	112 KB	0 B	92 B
$\color{green}{\rule{8pt}{8pt}}$ Typed arrays	0 B	0 B	0 B	0 B
$\color{yellow}{\rule{8pt}{8pt}}$ System objects	0 B	0 B	0 B	0 B
$\color{violet}{\rule{8pt}{8pt}}$ Other JS objs	2 MB	2 MB	$\text{+1.4 KB}$	176 B
$\color{pink}{\rule{8pt}{8pt}}$ Other non-JS objs	5 MB	5 MB	$\text{+80 KB}$	39 KB

Download representative heap snapshot: base / head

📦 Bundle Stats

Chunk size diff (2 updated, 0 added, 0 removed)

Chunk	Base	Head	Δ	Δ (%)
(total)	5.9 MB	6 MB	$\color{orange}{\text{+5.3 KB}}$	$\text{+0.1\%}$
search-index:settings ja-JP/sQ48aJMKG-BeoaExnI.js → ja-JP/sQ48aJMKG-BBqZdHNW.js	28 KB	33 KB	$\color{orange}{\text{+5 KB}}$	$\color{orange}{\text{+17.7\%}}$
src/pages/settings/privacy.vue ja-JP/sQ48aJMKG-B2Z-He11.js → ja-JP/sQ48aJMKG-ClxZ9Qf5.js	19 KB	19 KB	$\text{+278 B}$	$\color{orange}{\text{+1.5\%}}$
(other generated chunks)	2 MB	2 MB	0 B	0%

Startup chunk size (0 updated, 0 added, 0 removed)

Chunk	Base	Head	Δ	Δ (%)
(total)	1 MB	1 MB	0 B	0%
(other generated chunks)	759 KB	759 KB	0 B	0%
(other)	284 KB	284 KB	0 B	0%

Startup chunks are the Vite entry for src/_boot_.ts and its static imports.

	Bundles	Modules	Entries	Imports		Size
				Static	Dynamic	Rendered	Gzip	Brotli
Base	469	2,857	21	10,347	333	10 MB	2.8 MB	2.4 MB
Head	469	2,857	21	10,348	333	10 MB	2.8 MB	2.4 MB
Δ	0	0	0	$\color{orange}{\text{+1}}$	0	$\color{orange}{\text{+3.4 KB}}$	$\text{+752 B}$	$\text{+639 B}$
Δ (%)	0%	0%	0%	$\text{+0\%}$	0%	$\text{+0\%}$	$\text{+0\%}$	$\text{+0\%}$

Open treemap HTML

[syuilo]

🙏