Skip to content

Commit 25674ce

Browse files
committed
Update comment for size about main thread
1 parent e0975ca commit 25674ce

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

‎Zend/zend_call_stack.c‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -819,10 +819,13 @@ static bool zend_call_stack_get_aix_pthread(zend_call_stack *stack)
819819
* The top of the stack (stackend) is not page aligned, there's some
820820
* internal stuff above it. Thankfully, we don't need page alignment.
821821
*
822-
* The size is a little weird. The stacksize field is smaller than
823-
* subtracting the bottom (stackaddr) from the top; it's about 0x888
824-
* to 0x1888 above stackaddr. I'm assuming it rounds the bottom of the
825-
* stack to page alignment?
822+
* The size is a little weird. The stacksize field for child threads
823+
* is smaller than subtracting the bottom (stackaddr) from the top;
824+
* it's about 0x888 to 0x1888 above stackaddr. I'm assuming it rounds
825+
* the bottom of the stack to page alignment? The main thread size is
826+
* the same as end - addr, but it is variable between systems; also
827+
* assuming there's stuff at the top of the stack that gets taken off,
828+
* regardless of maximum declared size.
826829
*
827830
* A somewhat crude diagram is available here:
828831
* https://www.ibm.com/docs/en/aix/7.2.0?topic=tuning-thread-environment-variables

0 commit comments

Comments
 (0)