Skip to content

Commit 94bc9ee

Browse files
NiteshDhanpalclaude
andcommitted
revert: correlate business spans with active observability trace (#465)
Reverts #465 (src/agentex/lib/core/tracing/obs_ids.py and trace.py). The dependent open PRs #466/#467/#471 build on obs_ids and are intentionally left open for now. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent c67e177 commit 94bc9ee

2 files changed

Lines changed: 0 additions & 96 deletions

File tree

‎src/agentex/lib/core/tracing/obs_ids.py‎

Lines changed: 0 additions & 83 deletions
This file was deleted.

‎src/agentex/lib/core/tracing/trace.py‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from agentex.types.span import Span
1212
from agentex.lib.utils.logging import make_logger
1313
from agentex.lib.utils.model_utils import recursive_model_dump
14-
from agentex.lib.core.tracing.obs_ids import obs_correlation
1514
from agentex.lib.core.tracing.span_error import set_span_error
1615
from agentex.lib.core.tracing.span_queue import (
1716
SpanEventType,
@@ -80,12 +79,6 @@ def start_span(
8079

8180
serialized_input = recursive_model_dump(input) if input else None
8281
serialized_data = recursive_model_dump(data) if data else None
83-
# Tag the business span with the active observability trace_id/span_id
84-
# (OTel/ddtrace) so it can be correlated to the per-turn obs trace. The
85-
# business trace_id stays the run-level task id -- see obs_ids.py.
86-
obs = obs_correlation()
87-
if obs:
88-
serialized_data = {**(serialized_data or {}), **obs}
8982
id = str(uuid.uuid4())
9083

9184
span = Span(
@@ -236,12 +229,6 @@ async def start_span(
236229

237230
serialized_input = recursive_model_dump(input) if input else None
238231
serialized_data = recursive_model_dump(data) if data else None
239-
# Tag the business span with the active observability trace_id/span_id
240-
# (OTel/ddtrace) so it can be correlated to the per-turn obs trace. The
241-
# business trace_id stays the run-level task id -- see obs_ids.py.
242-
obs = obs_correlation()
243-
if obs:
244-
serialized_data = {**(serialized_data or {}), **obs}
245232
id = str(uuid.uuid4())
246233

247234
span = Span(

0 commit comments

Comments
 (0)