Skip to content

Commit beda56b

Browse files
committed
fix(ci): restate RuboCop's default excludes alongside the e2e-cli one
An AllCops Exclude replaces the default list instead of extending it, so adding e2e-cli silently un-excluded vendor/**, and RuboCop then loaded the .rubocop.yml shipped inside a vendored gem, which requires a plugin this project does not depend on.
1 parent b1af51f commit beda56b

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

‎.rubocop.yml‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ AllCops:
55
SuggestExtensions: false
66
NewCops: disable
77
Exclude:
8+
# Setting Exclude here REPLACES RuboCop's default exclude list rather than
9+
# extending it, so the paths it normally skips have to be restated. Without
10+
# them RuboCop walks vendor/bundle and loads the .rubocop.yml shipped inside
11+
# gems there, which pulls in plugins this project does not depend on.
12+
- 'vendor/**/*'
13+
- '.gem/**/*'
14+
- 'node_modules/**/*'
15+
- '.git/**/*'
816
# Standalone cross-SDK test harness: carries its own Gemfile and is absent
917
# from the gemspec's spec.files, so it is not held to the gem's style.
1018
- 'e2e-cli/**/*'

0 commit comments

Comments
 (0)