Backport release/v6.3: fix: support iavl.* pruning config keys with legacy fallback (#2769)

Backport of #2767 to `release/v6.3`.

---------

Co-authored-by: yirenz <blindchaser@users.noreply.github.com>
Co-authored-by: Masih H. Derkani <m@derkani.org>

Author: 3 people

README.md

@@ -8,7 +8,7 @@ Sei is the fastest general purpose L1 blockchain and the first parallelized EVM.
 **Sei** is a high-performance, low-fee, delegated proof-of-stake blockchain designed for developers. It supports optimistic parallel execution of both EVM and CosmWasm, opening up new design possibilities. With unique optimizations like twin turbo consensus and SeiDB, Sei ensures consistent 400ms block times and a transaction throughput that’s orders of magnitude higher than Ethereum. This means faster, more cost-effective operations. Plus, Sei’s seamless interoperability between EVM and CosmWasm gives developers native access to the entire Cosmos ecosystem, including IBC tokens, multi-sig accounts, fee grants, and more.
 
 # Documentation
-For the most up to date documentation please visit https://www.docs.sei.io/
+For the most up-to-date documentation please visit https://www.docs.sei.io/
 
 # Sei Optimizations
 Sei introduces four major innovations:

sei-cosmos/server/pruning.go

@@ -15,17 +15,35 @@ import (
 // PruningOptions. If a pruning strategy is provided, that will be parsed and
 // returned, otherwise, it is assumed custom pruning options are provided.
 func GetPruningOptionsFromFlags(appOpts types.AppOptions) (storetypes.PruningOptions, error) {
-	strategy := strings.ToLower(cast.ToString(appOpts.Get(FlagPruning)))
+	// New format (iavl.*) takes priority, fallback to legacy top-level keys for backward compatibility
+	strategy := cast.ToString(appOpts.Get(FlagIAVLPruning))
+	if strategy == "" {
+		strategy = cast.ToString(appOpts.Get(FlagPruning))
+	}
+	strategy = strings.ToLower(strategy)
 
 	switch strategy {
 	case storetypes.PruningOptionDefault, storetypes.PruningOptionNothing, storetypes.PruningOptionEverything:
 		return storetypes.NewPruningOptionsFromString(strategy), nil
 
 	case storetypes.PruningOptionCustom:
+		keepRecent := appOpts.Get(FlagIAVLPruningKeepRecent)
+		if keepRecent == nil {
+			keepRecent = appOpts.Get(FlagPruningKeepRecent)
+		}
+		keepEvery := appOpts.Get(FlagIAVLPruningKeepEvery)
+		if keepEvery == nil {
+			keepEvery = appOpts.Get(FlagPruningKeepEvery)
+		}
+		interval := appOpts.Get(FlagIAVLPruningInterval)
+		if interval == nil {
+			interval = appOpts.Get(FlagPruningInterval)
+		}
+
 		opts := storetypes.NewPruningOptions(
-			cast.ToUint64(appOpts.Get(FlagPruningKeepRecent)),
-			cast.ToUint64(appOpts.Get(FlagPruningKeepEvery)),
-			cast.ToUint64(appOpts.Get(FlagPruningInterval)),
+			cast.ToUint64(keepRecent),
+			cast.ToUint64(keepEvery),
+			cast.ToUint64(interval),
 		)
 
 		if err := opts.Validate(); err != nil {

sei-cosmos/server/pruning_test.go

@@ -25,6 +25,15 @@ func TestGetPruningOptionsFromFlags(t *testing.T) {
 			},
 			expectedOptions: types.PruneNothing,
 		},
+		{
+			name: FlagIAVLPruning,
+			initParams: func() *viper.Viper {
+				v := viper.New()
+				v.Set(FlagIAVLPruning, types.PruningOptionNothing)
+				return v
+			},
+			expectedOptions: types.PruneNothing,
+		},
 		{
 			name: "custom pruning options",
 			initParams: func() *viper.Viper {
@@ -42,6 +51,23 @@ func TestGetPruningOptionsFromFlags(t *testing.T) {
 				Interval:   10,
 			},
 		},
+		{
+			name: "custom pruning options iavl",
+			initParams: func() *viper.Viper {
+				v := viper.New()
+				v.Set(FlagIAVLPruning, types.PruningOptionCustom)
+				v.Set(FlagIAVLPruningKeepRecent, 1234)
+				v.Set(FlagIAVLPruningKeepEvery, 4321)
+				v.Set(FlagIAVLPruningInterval, 10)
+
+				return v
+			},
+			expectedOptions: types.PruningOptions{
+				KeepRecent: 1234,
+				KeepEvery:  4321,
+				Interval:   10,
+			},
+		},
 		{
 			name: types.PruningOptionDefault,
 			initParams: func() *viper.Viper {
@@ -51,6 +77,17 @@ func TestGetPruningOptionsFromFlags(t *testing.T) {
 			},
 			expectedOptions: types.PruneDefault,
 		},
+		{
+			name: "new format takes priority over legacy",
+			initParams: func() *viper.Viper {
+				v := viper.New()
+				// Both old and new format present - new format should win
+				v.Set(FlagPruning, types.PruningOptionNothing)
+				v.Set(FlagIAVLPruning, types.PruningOptionEverything)
+				return v
+			},
+			expectedOptions: types.PruneEverything,
+		},
 	}
 
 	for _, tt := range tests {

sei-cosmos/server/start.go

@@ -54,10 +54,19 @@ const (
 	FlagProfile            = "profile"
 	FlagInvCheckPeriod     = "inv-check-period"
 
-	FlagPruning                      = "pruning"
-	FlagPruningKeepRecent            = "pruning-keep-recent"
-	FlagPruningKeepEvery             = "pruning-keep-every"
-	FlagPruningInterval              = "pruning-interval"
+	// Legacy pruning flags (kept for backward compatibility)
+	FlagPruning           = "pruning"
+	FlagPruningKeepRecent = "pruning-keep-recent"
+	FlagPruningKeepEvery  = "pruning-keep-every"
+	FlagPruningInterval   = "pruning-interval"
+
+	// New pruning config keys under [iavl] section (v6.3.0+)
+	// TODO: Remove legacy fallback once all nodes have migrated to v6.3.0+
+	FlagIAVLPruning           = "iavl.pruning"
+	FlagIAVLPruningKeepRecent = "iavl.pruning-keep-recent"
+	FlagIAVLPruningKeepEvery  = "iavl.pruning-keep-every"
+	FlagIAVLPruningInterval   = "iavl.pruning-interval"
+
 	FlagIndexEvents                  = "index-events"
 	FlagMinRetainBlocks              = "min-retain-blocks"
 	FlagIAVLCacheSize                = "iavl-cache-size"