fix(desktop): clarify consent actions and await native test readiness

Author: waleedlatif1

apps/desktop/e2e/browser-page-dialogs.spec.ts

@@ -433,6 +433,12 @@ createRoot(document.getElementById('root')).render(createElement(Fixture));`,
       await userInput('#draft')
       await panelAction({ action: 'reload' })
       await expect(shell.getByRole('button', { name: 'Stay', exact: true })).toBeFocused()
+      await shell.getByRole('dialog').screenshot({
+        path: test.info().outputPath('leave-page-modal.png'),
+        animations: 'allow',
+        caret: 'initial',
+      })
+      await expect(shell.getByRole('button', { name: 'Stay', exact: true })).toBeFocused()
       await shell.keyboard.press('Escape')
       await expect.poll(pageDialog).toBeNull()
       await expect

apps/desktop/e2e/executor-sim.ts

@@ -462,6 +462,7 @@ export async function launch(
   app.context().pages().forEach(leaveDialogsToDesktop)
   app.context().on('page', leaveDialogsToDesktop)
   const window = await app.firstWindow()
+  await window.waitForURL((url) => url.origin === sim.origin, { waitUntil: 'load' })
   return { app, window }
 }
 

apps/desktop/e2e/local-files.spec.ts

@@ -316,12 +316,12 @@ createRoot(document.getElementById('settings')).render(
       })
       const shown = app.waitForEvent('window')
       await permission.prompt
-        .getByRole('button', { name: 'Allow all files…', exact: true })
+        .getByRole('button', { name: 'Full file access', exact: true })
         .click({ noWaitAfter: true })
       const confirmation = await shown
       calls.expiringFullAccess = undefined
       await confirmation
-        .getByRole('button', { name: 'Allow all files', exact: true })
+        .getByRole('button', { name: 'Enable', exact: true })
         .click({ noWaitAfter: true })
       expect(await permission.result).toMatchObject({ ok: false })
       expect(
@@ -347,7 +347,7 @@ createRoot(document.getElementById('settings')).render(
       const permission = await requestPermission({ operation: 'read', toolCallId: 'fullAccess' })
       const confirmationShown = app.waitForEvent('window')
       await permission.prompt
-        .getByRole('button', { name: 'Allow all files…', exact: true })
+        .getByRole('button', { name: 'Full file access', exact: true })
         .click({ noWaitAfter: true })
       const confirmation = await confirmationShown
       await expect(confirmation.getByRole('button', { name: 'Cancel', exact: true })).toBeFocused()
@@ -365,14 +365,14 @@ createRoot(document.getElementById('settings')).render(
       ).toMatchObject({ fullFileAccess: false })
       const acceptedConfirmation = app.waitForEvent('window')
       await folderPrompt
-        .getByRole('button', { name: 'Allow all files…', exact: true })
+        .getByRole('button', { name: 'Full file access', exact: true })
         .click({ noWaitAfter: true })
       const allowAll = await acceptedConfirmation
       await allowAll.screenshot({
         path: test.info().outputPath('full-file-access-confirmation.png'),
       })
       await allowAll
-        .getByRole('button', { name: 'Allow all files', exact: true })
+        .getByRole('button', { name: 'Enable', exact: true })
         .click({ noWaitAfter: true })
       expect(await permission.result).toMatchObject({
         ok: true,
@@ -939,7 +939,10 @@ createRoot(document.getElementById('settings')).render(
         try {
           await toggle.click()
           await expect(
-            window.getByText('Could not update file access', { exact: true })
+            window.getByText(
+              'Could not save file access settings. Your previous setting may return after restarting Sim.',
+              { exact: true }
+            )
           ).toBeVisible()
           await expect(toggle).not.toBeChecked()
           expect(

apps/desktop/e2e/smoke.spec.ts

@@ -138,6 +138,7 @@ test.describe('desktop shell smoke', () => {
   test('OAuth popups share the session without inheriting the privileged preload', async () => {
     app = await launchApp(origin)
     const window = await app.firstWindow()
+    await window.waitForURL(`${origin}/home`, { waitUntil: 'load' })
     await window.evaluate(() => {
       document.cookie = 'sim-e2e-session=shared; Path=/; SameSite=Lax'
     })
@@ -319,7 +320,7 @@ test.describe('desktop shell smoke', () => {
     await window.locator('#server').click()
     const picker = await pickerPromise
 
-    expect(picker.url()).toBe('sim-shell://pages/server.html')
+    await expect(picker).toHaveURL('sim-shell://pages/server.html')
     await expect(picker.getByRole('dialog', { name: 'Sim server', exact: true })).toBeVisible()
     await expect(picker.getByLabel('Server URL')).toHaveValue('http://127.0.0.1:1')
     await expect(picker.getByLabel('Server URL')).toBeFocused()

apps/desktop/src/main/desktop-settings.ts

@@ -187,7 +187,9 @@ export function createDesktopSettingsService(
       if (!deps.config.flush()) {
         deps.config.set('fullFileAccess', false)
         deps.onFullFileAccessChanged?.(read())
-        throw new Error('Could not save file access settings')
+        throw new Error(
+          'Could not save file access settings. Your previous setting may return after restarting Sim.'
+        )
       }
       const preferences = read()
       deps.onFullFileAccessChanged?.(preferences)

apps/desktop/src/main/local-file-permissions.ts

@@ -197,7 +197,7 @@ export class LocalFilePermissions {
       buttons: [
         'Allow folder',
         "Don't allow",
-        ...(this.enableFullFileAccess ? ['Allow all files…'] : []),
+        ...(this.enableFullFileAccess ? ['Full file access'] : []),
       ],
       defaultId: 1,
       cancelId: 1,
@@ -209,10 +209,10 @@ export class LocalFilePermissions {
       if (result.response === 2 && this.enableFullFileAccess) {
         const confirmation = {
           signal,
-          title: 'Allow full file access?',
+          title: 'Enable full file access?',
           message: `Sim can read and import files from any folder on this computer across chats on ${context.origin}.`,
           detail: 'Turn this off in Settings → Desktop → Full file access.',
-          buttons: ['Allow all files', 'Cancel'],
+          buttons: ['Enable', 'Cancel'],
           defaultId: 1,
           cancelId: 1,
         }

apps/sim/app/workspace/[workspaceId]/settings/components/desktop/desktop.tsx

@@ -77,7 +77,7 @@ export function Desktop() {
   const { pending: fullFileAccessPending, mutate: setFullFileAccess } =
     useDesktopPreferenceMutation(
       async (bridge, enabled: boolean) => bridge.settings.setFullFileAccess?.(enabled),
-      'Could not update file access',
+      'Could not save file access settings. Your previous setting may return after restarting Sim.',
       setPreferences
     )