Skip to content

Commit 569288f

Browse files
committed
ci: run the ci gate on cancelled runs so a cancelled head never passes
1 parent 8fb80bf commit 569288f

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎.github/workflows/checks.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,10 +611,12 @@ jobs:
611611
# One status for every check above: the single check to require on a branch ruleset, so adding,
612612
# sharding or renaming a job never means editing the ruleset. Skipped is a pass (the desktop live
613613
# suite skips on pull requests that cannot affect it); a failure or a cancellation is not.
614+
# `always()`, not `!cancelled()`: a skipped job satisfies a required check, so a gate that skips
615+
# on a cancelled run would report a cancelled head commit as passing.
614616
ci:
615617
name: ci
616618
needs: [integration, e2e, desktop-changes, desktop-live, lint, test, build]
617-
if: ${{ !cancelled() }}
619+
if: ${{ always() }}
618620
runs-on: *runner-2vcpu
619621
timeout-minutes: 5
620622
steps:

0 commit comments

Comments
 (0)