test(desktop): cover quiet navigation and full access consent

Author: waleedlatif1

apps/desktop/e2e/browser-page-dialogs.spec.ts

@@ -364,6 +364,40 @@ createRoot(document.getElementById('root')).render(createElement(Fixture));`,
     await panelAction({ action: 'reload' })
     await expect.poll(() => pageTitle()).toBe('form')
 
+    await check('clean reloads and navigation never ask to discard changes', async () => {
+      await panelAction({ action: 'reload' })
+      await expect.poll(() => pageTitle()).toBe('form')
+      expect(await pageDialog()).toBeNull()
+      await panelAction({ action: 'navigate', url: `${site}/next` })
+      await expect.poll(pageUrl).toBe(`${site}/next`)
+      expect(await pageDialog()).toBeNull()
+      await panelAction({ action: 'back' })
+      await expect.poll(pageUrl).toBe(`${site}/form`)
+      expect(await pageDialog()).toBeNull()
+    })
+
+    await check('clearing a draft removes the leave warning', async () => {
+      await userInput('#draft', 'temporary draft')
+      await inPage("document.getElementById('draft').value = ''")
+      await panelAction({ action: 'navigate', url: `${site}/next` })
+      await expect.poll(pageUrl).toBe(`${site}/next`)
+      expect(await pageDialog()).toBeNull()
+      await panelAction({ action: 'navigate', url: `${site}/form` })
+      await expect.poll(pageUrl).toBe(`${site}/form`)
+    })
+
+    await check('same-page navigation preserves a draft without a leave warning', async () => {
+      await userInput('#draft', 'same-page draft')
+      await panelAction({ action: 'navigate', url: `${site}/form#section` })
+      await expect.poll(pageUrl).toBe(`${site}/form#section`)
+      expect(await pageDialog()).toBeNull()
+      expect(await inPage<string>("document.getElementById('draft').value")).toBe('same-page draft')
+      await panelAction({ action: 'back' })
+      await expect.poll(pageUrl).toBe(`${site}/form`)
+      expect(await pageDialog()).toBeNull()
+      await inPage("document.getElementById('draft').value = ''")
+    })
+
     await check('leaving a draft from the URL bar asks, and Stay keeps it', async () => {
       await userInput('#draft', 'draft')
       await expect

apps/desktop/e2e/local-files.spec.ts

@@ -315,7 +315,40 @@ createRoot(document.getElementById('settings')).render(
       await expect(
         window.getByRole('switch', { name: 'Full file access', exact: true })
       ).not.toBeChecked()
-      await window.getByRole('switch', { name: 'Full file access', exact: true }).click()
+      const permission = await requestPermission({ operation: 'read', toolCallId: 'fullAccess' })
+      const confirmationShown = app.waitForEvent('window')
+      await permission.prompt
+        .getByRole('button', { name: 'Allow all files…', exact: true })
+        .click({ noWaitAfter: true })
+      const confirmation = await confirmationShown
+      await expect(confirmation.getByRole('button', { name: 'Cancel', exact: true })).toBeFocused()
+      const returnedPrompt = app.waitForEvent('window')
+      await confirmation
+        .getByRole('button', { name: 'Cancel', exact: true })
+        .click({ noWaitAfter: true })
+      const folderPrompt = await returnedPrompt
+      expect(
+        await window.evaluate(async () =>
+          (
+            globalThis as typeof globalThis & { simDesktop: SimDesktopApi }
+          ).simDesktop.settings.getPreferences()
+        )
+      ).toMatchObject({ fullFileAccess: false })
+      const acceptedConfirmation = app.waitForEvent('window')
+      await folderPrompt
+        .getByRole('button', { name: 'Allow all files…', exact: true })
+        .click({ noWaitAfter: true })
+      const allowAll = await acceptedConfirmation
+      await allowAll.screenshot({
+        path: test.info().outputPath('full-file-access-confirmation.png'),
+      })
+      await allowAll
+        .getByRole('button', { name: 'Allow all files', exact: true })
+        .click({ noWaitAfter: true })
+      expect(await permission.result).toMatchObject({
+        ok: true,
+        data: { text: 'full access contents' },
+      })
       await expect(
         window.getByRole('switch', { name: 'Full file access', exact: true })
       ).toBeChecked()
@@ -383,11 +416,11 @@ createRoot(document.getElementById('settings')).render(
       await expect(
         window.getByRole('switch', { name: 'Full file access', exact: true })
       ).not.toBeChecked()
-      const permission = await requestPermission({ operation: 'read', toolCallId: 'fullAccess' })
-      await permission.prompt
+      const revoked = await requestPermission({ operation: 'read', toolCallId: 'fullAccess' })
+      await revoked.prompt
         .getByRole('button', { name: "Don't allow", exact: true })
         .click({ noWaitAfter: true })
-      expect(await permission.result).toMatchObject({ ok: false })
+      expect(await revoked.result).toMatchObject({ ok: false })
     })
     await test.step('a folder grant works in another chat but does not permit symlink escapes', async () => {
       expect(await invoke({ operation: 'read', toolCallId: 'otherChat' })).toMatchObject({