Skip to content

Commit fcf4158

Browse files
committed
refactor(update-platforms): hoist the version cap to one constant
The "keep at most 5 versions" limit was duplicated (and inconsistently expressed) in two places. Replace with MAX_VERSIONS_PER_PLATFORM. No behaviour change.
1 parent eae6eb3 commit fcf4158

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

‎scripts/update-platforms.py‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ class PlatformUpdater:
108108
# Distributions to exclude
109109
EXCLUDED_DISTRIBUTIONS = {"embedded-cluster"}
110110

111+
# Keep at most this many (latest) minor version lines per platform.
112+
MAX_VERSIONS_PER_PLATFORM = 5
113+
111114
def __init__(self, platforms_yaml_path: str = "catalog/platforms.yaml"):
112115
self.platforms_yaml_path = Path(platforms_yaml_path)
113116
self.replicated_data = None
@@ -258,10 +261,7 @@ def update_platform_versions(self, platform: Dict, distribution_data: Dict) -> D
258261
distribution_data["versions"], distribution
259262
)
260263

261-
# Limit to reasonable number of versions (e.g., last 5 minor versions)
262-
max_versions = 5
263-
if len(latest_versions) > max_versions:
264-
latest_versions = latest_versions[:max_versions]
264+
latest_versions = latest_versions[: self.MAX_VERSIONS_PER_PLATFORM]
265265

266266
platform["versions"] = latest_versions
267267
return platform
@@ -331,9 +331,7 @@ def update_platforms(self) -> Dict:
331331
latest_versions = self.get_latest_patch_versions(
332332
ionos_versions, "ionos"
333333
)
334-
# Limit to 5 versions
335-
if len(latest_versions) > 5:
336-
latest_versions = latest_versions[:5]
334+
latest_versions = latest_versions[: self.MAX_VERSIONS_PER_PLATFORM]
337335
platform["versions"] = latest_versions
338336

339337
print(f" ✓ Updated {platform_id}")

0 commit comments

Comments
 (0)