Skip to content

Commit 1f08a52

Browse files
committed
Give manual activity tests time for the start handshake
test_manual_heartbeat and its siblings start a standalone activity with a 5s start-to-close timeout, then wait for the activity to report that it started through an EventWorkflow before completing, cancelling, failing or heartbeating it by ID. That handshake includes the first workflow task of a cold worker, which on a loaded macOS runner took over 5s; the attempt timed out and the heartbeat failed with RPCError NOT_FOUND ("activity not found for ID"). Nothing in these tests depends on the attempt timing out, so give the attempt a minute.
1 parent fa04bc6 commit 1f08a52

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎tests/test_activity.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@ async def test_manual_completion(client: Client, env: WorkflowEnvironment):
752752
ActivityInput(event_workflow_id=event_workflow_id),
753753
id=activity_id,
754754
task_queue=task_queue,
755-
start_to_close_timeout=timedelta(seconds=5),
755+
start_to_close_timeout=timedelta(minutes=1),
756756
)
757757

758758
async with Worker(
@@ -794,7 +794,7 @@ async def test_manual_cancellation(client: Client, env: WorkflowEnvironment):
794794
ActivityInput(event_workflow_id=event_workflow_id),
795795
id=activity_id,
796796
task_queue=task_queue,
797-
start_to_close_timeout=timedelta(seconds=5),
797+
start_to_close_timeout=timedelta(minutes=1),
798798
)
799799

800800
async with Worker(
@@ -855,7 +855,7 @@ async def test_manual_failure(client: Client, env: WorkflowEnvironment):
855855
ActivityInput(event_workflow_id=event_workflow_id),
856856
id=activity_id,
857857
task_queue=task_queue,
858-
start_to_close_timeout=timedelta(seconds=5),
858+
start_to_close_timeout=timedelta(minutes=1),
859859
)
860860
async with Worker(
861861
client,
@@ -932,7 +932,7 @@ async def test_manual_heartbeat(client: Client, env: WorkflowEnvironment):
932932
),
933933
id=activity_id,
934934
task_queue=task_queue,
935-
start_to_close_timeout=timedelta(seconds=5),
935+
start_to_close_timeout=timedelta(minutes=1),
936936
)
937937
wait_for_activity_start_wf_handle = await client.start_workflow(
938938
EventWorkflow.wait,

0 commit comments

Comments
 (0)