Skip to content

Commit 412c989

Browse files
committed
Cover system Nexus tracing span names
1 parent 836a912 commit 412c989

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎tests/contrib/opentelemetry/test_opentelemetry_plugin.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,10 +206,12 @@ async def test_otel_workflow_signal_with_start_propagates_trace_headers(
206206
):
207207
if env.supports_time_skipping:
208208
pytest.skip("Nexus tests don't work with the Java test server")
209+
exporter = InMemorySpanExporter()
209210
provider = create_tracer_provider()
211+
provider.add_span_processor(SimpleSpanProcessor(exporter))
210212
opentelemetry.trace.set_tracer_provider(provider)
211213
config = client.config()
212-
config["plugins"] = [OpenTelemetryPlugin()]
214+
config["plugins"] = [OpenTelemetryPlugin(add_temporal_spans=True)]
213215
client = Client(**config)
214216

215217
async with new_worker(
@@ -226,6 +228,7 @@ async def test_otel_workflow_signal_with_start_propagates_trace_headers(
226228
)
227229
assert await caller.result() == target_id
228230
assert await client.get_workflow_handle(target_id).result() is True
231+
assert any(span.name == "SignalWithStart" for span in exporter.get_finished_spans())
229232

230233

231234
@workflow.defn

0 commit comments

Comments
 (0)