Repository navigation
Conversation
01mf02
force-pushed
the
ros-audit
branch
2 times, most recently
from
February 12, 2026 10:38
c4586cb to
3e1e5be
Compare
01mf02
force-pushed
the
ros-audit
branch
2 times, most recently
from
February 23, 2026 18:23
d3b4a76 to
ec88883
Compare
vlasky
pushed a commit
to vlasky/jaqi
that referenced
this pull request
Jul 20, 2026
Address ROS audit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses problems uncovered by @dnet as part of a ROS audit for jaq's multi-format support. Thanks a lot for all your effort --- I appreciate it!
These problems are:
toml-edittotoml-span. #398.stacker, but even if we could make parsing stack-overflow-proof, basically all other parts of jaq might then start failing (Drop, printing, ...). Furthermore, stack overflows are a problem that can inherently occur in jaq scripts --- even in something likejaq -n 'def f: 1+f; f'(jq fails with an error here, too). The same problem holds for memory consumption, by the way. jaq cannot guarantee to run out of memory, and similarly, it cannot guarantee to not overflow the stack. This is now also documented in the README.Unfortunately, these links are not public.
BigUint::from_str_radixaccepts strings with underscores as numbers