Repository navigation
refactor(standards): unify PSWAP paybacks with fixed recipients - #4074
Open
partylikeits1983 wants to merge 38 commits into
Open
partylikeits1983 wants to merge 38 commits into
partylikeits1983 wants to merge 38 commits into
Conversation
partylikeits1983
changed the title
partylikeits1983
added
the
standards
mmagician
reviewed
Oct 21, 2026
Comment on lines
57
to
59
| Public { recipient: P2idNoteRecipient }, | ||
| /// Private P2ID paybacks to a fixed recipient commitment, with an explicit discovery tag. | ||
| Private { recipient: Word, tag: NoteTag }, |
Collaborator
There was a problem hiding this comment.
could we also not add a tag with the public payback variant, and simplify things further?
# Conflicts: # bin/bench-transaction/bench-tx.json # crates/miden-standards/asm/standards/notes/pswap.masm # crates/miden-standards/src/note/costs/table.rs # crates/miden-standards/src/note/pswap.rs # crates/miden-testing/tests/scripts/pswap.rs # docs/src/note.md
# Conflicts: # bin/bench-transaction/bench-tx.json
partylikeits1983
marked this pull request as ready for review
October 21, 2026 17:47
mmagician
reviewed
Oct 22, 2026
# Conflicts: # crates/miden-standards/asm/standards/notes/pswap.masm
partylikeits1983
marked this pull request as draft
October 22, 2026 12:16
# Conflicts: # crates/miden-standards/src/note/pswap.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a fixed recipient hash for both public and private PSWAP paybacks. Public paybacks use P2ID; private fills can target any note script, while private cancellation requires a P2ID preimage.
Fill attachments distinguish successive payments. Both modes accept explicit discovery tags;
PswapNote::PAYBACK_TAGprovides a shared tag without identifying the owner. Public reclaim still requires the creator account.