Skip to content

Guard CircleCI behind manual approval#601

Merged
akostadinov merged 1 commit into
masterfrom
ci/manual-approval-gate
Jul 14, 2026
Merged

Guard CircleCI behind manual approval#601
akostadinov merged 1 commit into
masterfrom
ci/manual-approval-gate

Conversation

@akostadinov-bot

@akostadinov-bot akostadinov-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

Summary

  • Adds an approve job (type: approval) to the build_and_test_docker workflow
  • All CI jobs (build, build_ssl, docker-build) now require manual approval before running
  • This prevents CI from auto-failing on PRs from non-maintainers who have no way to fix CI themselves

How it works

When a PR is opened, CircleCI will show a pending approve job. A maintainer must click "Approve" in the CircleCI UI to trigger the actual CI jobs. This gives maintainers control over when CI resources are used and prevents PRs from being marked as failing when CI can't run.

Test plan

  • Open a test PR and verify CircleCI shows the approval gate
  • Approve the job and verify downstream jobs run normally

🤖 Generated with Claude Code

jlledom
jlledom previously approved these changes Jul 14, 2026
@akostadinov-bot akostadinov-bot Bot force-pushed the ci/manual-approval-gate branch 2 times, most recently from e08b327 to f3db6db Compare July 14, 2026 08:19
Add an approval gate for PR branches (non-master) so CI does not
auto-run on PRs from non-maintainers. Pushes to master (merges,
scheduled builds) run without approval.

Follows the same pattern as 3scale-toolbox.

Assisted-By: claude-opus-4-6
@akostadinov-bot akostadinov-bot Bot force-pushed the ci/manual-approval-gate branch from f3db6db to 3836a3b Compare July 14, 2026 09:56
@akostadinov akostadinov merged commit bc057dc into master Jul 14, 2026
12 checks passed
@akostadinov akostadinov deleted the ci/manual-approval-gate branch July 14, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants