Guard CircleCI behind manual approval#601
Merged
Merged
Conversation
2 tasks
jlledom
previously approved these changes
Jul 14, 2026
e08b327 to
f3db6db
Compare
Add an approval gate for PR branches (non-master) so CI does not auto-run on PRs from non-maintainers. Pushes to master (merges, scheduled builds) run without approval. Follows the same pattern as 3scale-toolbox. Assisted-By: claude-opus-4-6
f3db6db to
3836a3b
Compare
jlledom
approved these changes
Jul 14, 2026
madnialihussain
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approvejob (type: approval) to thebuild_and_test_dockerworkflowbuild,build_ssl,docker-build) now require manual approval before runningHow it works
When a PR is opened, CircleCI will show a pending
approvejob. A maintainer must click "Approve" in the CircleCI UI to trigger the actual CI jobs. This gives maintainers control over when CI resources are used and prevents PRs from being marked as failing when CI can't run.Test plan
🤖 Generated with Claude Code