Skip to content

Welcome Back's "Not me" doesn't clear "engrid-autofill" cookie set on the parent domain #374

Description

@bryancasler

Report from BC
Looks like the "Not me" feature in Remember Me is not clearing the associated cookie, only the page contents. I believe it did or was supposed to do that at some point so once clicked the identity would be gone. Do either of you know if that was the case @Fernando @Michael

Recording: https://cln.sh/pFbM0yJx
Clicked "Not me" does not clear the "engrid-autofill" cookie set on the parent domain ran.,orgTest: https://act.ran.org/page/90804/donate/1?assets=tc-pagetypes-test&debug=log&test

Response From MT:
Had a very quick look. I think because the cookie is set on another domain for RAN then it doesn’t work. Welcome Back would need to integrate with the remember me iframe to do this I think.

if remember me is on the page with an iframe, it should instead of the current simple cookie.remove("engrid-autofill"); send this to its iframe

      this.iframe.contentWindow.postMessage(
        JSON.stringify({
          key: this.cookieName, // get from remember me options
          value: {},
          operation: "write",
          expires: 1,
        }),
        "*"
      );

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions