Repository navigation
Conversation
Callers describe a run in one config instead of the flag matrix across the training and inference scripts. The wrapper validates that config before opening a trace and writes one report per job. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python -m TraceLens.Reporting.generate_perf_report_from_config --config run.yaml, also installed asTraceLens_generate_perf_report_from_config.defaultcalls the training report.inference_graph_capture,spec_dec, andpd_disaggregationcall the inference report. Shared report kwargs are top-level and apply to every job.platformis a bundled arch name resolved throughload_arch.enable_pseudo_ops,group_by_num_kernels,include_call_stack, andgroup_by_parent_moduledefault on when the selected function accepts them.spec_decandpd_disaggregationstill call the inference report.spec_decode(method,num_spec_tokens) is checked and kept on the plan. PD writesperf_report_<role>_rank<r>. Comparison stays a separate step: one wrapper call per trace, then compare.Test plan
pytest tests/test_perf_report_from_config.py(28 tests: schema, dispatch, recipe defaults, PD filenames, capture-merge hook, and a failed second job never calls the report function)