Repository navigation
Conversation
lauri9
force-pushed
the
rocm-deb-migration
branch
2 times, most recently
from
October 5, 2026 13:09
1b59e14 to
8e738cd
Compare
Replace the TheRock source build with runtime, JIT, and devel deb layers so CI no longer compiles ROCm. PyTorch, Triton, and the TheRock checkout pin stay on main; TheRock is cloned only for the PyTorch build scripts. Self-retiring shims cover nightly packaging gaps for amdsmi, ld.lld, and origami. Co-authored-by: Cursor <cursoragent@cursor.com>
Release notes now treat ROCM_RELEASE_ID and ROCM_DEB_SERIES as snapshot pins rather than TheRock commit overrides. Co-authored-by: Cursor <cursoragent@cursor.com>
The nightly image has no /opt/rocm/share/therock tree, so both benchmark workflows record installed package versions from the image. The ITT workflow passes its runner list into the architecture matrix. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the amdrocm-core metapackage with the libraries PyTorch and AITER JIT need. rocm_devel keeps LLVM static archives and developer tools; ROCM_PARENT=rocm_base builds the product stages without them. Co-authored-by: Cursor <cursoragent@cursor.com>
lauri9
force-pushed
the
rocm-deb-migration
branch
from
October 6, 2026 07:21
8e738cd to
a025e21
Compare
lauri9
marked this pull request as ready for review
October 6, 2026 09:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install ROCm in the CI image from a pinned nightly deb snapshot, and keep optional a lean runtime option.
Background
docker/Dockerfile.cibuilt ROCm from TheRock source, including ccache, git mirrors, and a full artifact install into/opt/rocm. That compile dominated CI image builds, and the image always carried the developer tree.This PR installs ROCm from a pinned TheRock nightly deb snapshot on the legacy multi-arch native index.
ROCM_RELEASE_IDandROCM_DEB_SERIESselect the snapshot.ROCM_GFX_TARGETSselects the architecture shards and is independent ofPYTORCH_ROCM_ARCH. The nightly version in this PR is chosen so that it closely matches the current version installed viaTHEROCK_COMMITonmain. We will move to the current multi-arch native index later with the next ROCm update.The default stages keep developer tools.
ROCM_PARENT=rocm_basebuilds the same stages without LLVM static archives outsidelib/clangand without the developer-tools packages. This manual path enables leaner "runtime" style images. The nightly image no longer has/opt/rocm/share/therock, so CI records installedamdrocm-*package versions instead.Goals
Replace the in-image ROCm source build with a pinned nightly deb install, and make the developer and lean runtime layouts explicit.
Tasks
docker/install_rocm_debs.sh, and drop the artifact manifests.llvm/bin/ld.lldpath, and the origami CMake package.rocm_tree,rocm_base, androcm_devel, withROCM_PARENTselecting the parent ofcore,deps, andfinal.docker/README.mdandCONTRIBUTING.md.ROCM_RELEASE_IDandROCM_DEB_SERIESas release-note pins, and stop diffingrocm-librariesandrocm-systemscommit overrides.Test plan
Performance tests
Compared this PR to v26.10 release candidate. Performance looks good on MI350X.
Other
ROCM_LIBRARIES_COMMIT_OVERRIDEandROCM_SYSTEMS_COMMIT_OVERRIDEare removed. A change that is not in the pinned nightly has to be published in a snapshot before this image can use it.amdsiloai/pytorch-xdit-staging:0539bf1-tempclocks in at 17.2GB as reported bydockervs. 21.5GB for v26.10