Skip to content

pldm: Generate signal for events with null data transfer handle #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spargaon wants to merge 1 commit into
base: integ_sp8
Choose a base branch
from
Open

pldm: Generate signal for events with null data transfer handle #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions platform-mc/event_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,21 @@ int EventManager::handlePlatformEvent(
logPldmErrorEvent(tid, eventId, eventClass, eventData, eventDataSize);

auto& terminus = it->second; // Reference for clarity

#ifdef OEM_AMD

@mahkurap mahkurap Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrieving the event data after sensor poll timeout may not be a good idea. After five seconds, the event data may become stale. Let us refactor the event polling independent of sensor polling.

if (!poll_event.data_transfer_handle) {
// Wrap the single uint32_t values into std::vector containers
uint8_t formatVersion = poll_event.format_version;
std::vector<uint32_t> handle = { poll_event.data_transfer_handle };
std::vector<uint32_t> sizes = { 0 };
std::vector<uint8_t> eventMsg = {}; // Empty vector for the last argument

handlePollEventData(tid, formatVersion, eventClass, poll_event.event_id,
handle, sizes, eventMsg);

return PLDM_SUCCESS;
}
#endif
terminus->pollEvent = true;
terminus->pollEventId = poll_event.event_id;
terminus->pollDataTransferHandle = poll_event.data_transfer_handle;
Expand Down