Improved license activation error messages - #207
Open
RasmusAlgoryx wants to merge 7 commits into
Open
RasmusAlgoryx wants to merge 7 commits into
RasmusAlgoryx wants to merge 7 commits into
Conversation
…/improved-license-activation-error-messages
FilipAlg
reviewed
Sep 15, 2026
| if ( agx.Runtime.instance().hasKey( "InstallationID" ) ) { | ||
| if ( info.IsFloating || agx.Runtime.instance().hasKey( "InstallationID" ) ) { | ||
| info.Type = LicenseType.Service; | ||
| info.UniqueId = agx.Runtime.instance().readValue( "InstallationID" ); |
Contributor
There was a problem hiding this comment.
Is this safe when we are not sure if he key exists?
Comment on lines
+158
to
+159
| info.Type = native.licenseType == -1 ? LicenseType.Unknown : LicenseType.Service; | ||
| info.TypeDescription = "Unknown"; |
Contributor
There was a problem hiding this comment.
Under what circumstances do we get "Unknown"?
| Log( $"AGXUnity.LicenseManager: {info} (Context: {context})" ); | ||
| } | ||
|
|
||
| private static void IssueLoadWarning( string warning, string context ) |
Contributor
There was a problem hiding this comment.
Is it reasonable to assume that these will only be called once for a load failure and that LastOperationError is unset prior to calling? Should they compound all errors/warnings somehow?
|
|
||
| m_scroll = EditorGUILayout.BeginScrollView( m_scroll ); | ||
|
|
||
| using ( new GUI.EnabledBlock( !IsUpdatingLicenseInformation && !IsBusy ) ) { |
Contributor
There was a problem hiding this comment.
Should this include an IsPlayingOrWillChangePlaymode check as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.