Repository navigation
feat: add deterministic MMR diversity reranker - #14
Merged
Merged
Conversation
Owner
|
Thanks so much for this, @77cjj! 🙏Clean, well-scoped, and right in line with the project's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds a dependency-free
MMRRerankerand wiresmmr/mmr:<lambda>into retrieval sweeps. It uses lexical relevance plus token-set Jaccard redundancy so users can measure relevance/diversity trade-offs without model downloads or network access.Closes #7.
Checklist
pytest -qpasses (all tests; two existing optional-extra skips)ruff check src testspassesretrieval-lab demoruns green offline/keylessCHANGELOG.mdupdatedCONTRIBUTING.mdNotes
The implementation is deterministic and uses original shortlist order as the final tie-breaker, so no RNG state or seed is needed.
ruff format --check src testscurrently reports pre-existing formatting drift across 32 files on currentmainwith Ruff 0.16.6; the files containing the new reranker and focused reranker tests were formatted, andruff checkis clean.