Repository navigation
Support apple's AWDL on their platforms - #26
Merged
Merged
Conversation
tv_usec was set to the full timeout in microseconds rather than the sub-second remainder, so any timeout of a second or more made select fail with EINVAL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…latforms Adds with_peer_to_peer() to ServiceBrowserBuilder and DNSServiceBuilder, which sets kDNSServiceFlagsIncludeP2P | kDNSServiceFlagsIncludeAWDL so services can be found/advertised without a shared network. Off by default, only available on Apple targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds Service::resolve_socket_addrs() on Apple platforms, which uses DNSServiceGetAddrInfo on the interface the service was found on. getaddrinfo doesn't search peer-to-peer interfaces, and IPv6 link-local results get scoped to their interface so they're usable directly. Includes a p2p example for register/browse across devices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e5744277b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
With peer-to-peer browsing, browse can report kDNSServiceInterfaceIndexP2P for a service. That placeholder was kept on Service and passed to DNSServiceGetAddrInfo, where it isn't valid, so resolve_socket_addrs could fail or time out for P2P services. Keep the concrete interface reported by the resolve callback instead, and fall back to any interface if only the placeholder is known. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.