Skip to content

fix(stems): surface archive job timeouts on mobile #14539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanjeffers wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(stems): surface archive job timeouts on mobile #14539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/mobile/src/components/download-track-archive-drawer/DownloadTrackArchiveDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,27 @@ const DownloadTrackArchiveDrawerContent = ({

const { mutate: cancelStemsArchiveJob } = useCancelStemsArchiveJob()

const { data: jobState } = useGetStemsArchiveJobStatus({
const {
data: jobState,
isError: isJobStatusError,
isTimedOut: isJobTimedOut
} = useGetStemsArchiveJobStatus({
jobId
})

// `isTimedOut` and `isError` have to be part of this, not just `failed`.
// A job that never leaves `waiting` — the archiver worker losing its Redis
// lock and holding every concurrency slot, for instance — is reported as a
// perfectly valid non-terminal state forever, so keying only off `failed`
// leaves the drawer spinning with no error and no retry until the user
// gives up. The shared hook already enforces STEMS_ARCHIVE_POLL_TIMEOUT_MS
// and hands back `isTimedOut`; web consumes it and mobile did not.
const hasError =
!isStartingDownload &&
(downloadError || initiateDownloadFailed || jobState?.state === 'failed')
(downloadError ||
initiateDownloadFailed ||
jobState?.state === 'failed' ||
(!!jobId && (isJobStatusError || isJobTimedOut)))

useEffect(() => {
if (hasError) {
Expand Down