Follow source-sized absolute gallery positions across viewports - #473
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime-written absolute
inset: top auto auto leftcoordinates remained frozen even after gallery tile widths were made fluid. Learn the source-observed vertical and horizontal offsets as separate bounded stylesheet rules. Only absolute elements with numeric four-part inset values are eligible; unrelated normal-flow top offsets retain their original behavior. Related: #436.Evidence
At https://www.donihomeimprovement.com/kitchens/ and
/work/, the previous capture matched image widths but retained x/y positions from 1440px. A fresh 17-route recapture with this change now has zero image-geometry differences on either route at 1600 and 1728; 390px interactivity still passes and the offline check reports zero findings. Other routes still fail on hero vertical offsets and Wix external requests.A neutral browser regression proves that the original frozen 442px gallery step follows the source at 390, 768, 1440, 1600 and 1728px after script removal. Focused capture/model suites: 49 passed; TypeScript and diff checks passed.
Finalization used the operator-authorized isolated direct fallback after Homeboy controller and Lab staging failures; fresh source comparison is the end-to-end verification.
AI assistance
OpenAI GPT-6 Sol via OpenCode measured Wix gallery positions, authored the candidate and neutral regression, and compared a fresh capture with the source under Chris Huber’s direction.