Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the existing layout geometry proof export with a source-derived discriminator for article image wells, making eligible geometry easier for downstream imports to identify and edit while retaining the existing bounds and overlap protections.
What changed
How to test
npm test -- src/lib/screenshot/layout-geometry-proof.test.ts; expect passes as recorded by Cook's deterministic gate.Compatibility
Additive proof-schema content: consumers can use the new `kind` discriminator, while existing node evidence and generic classifications remain available. Runtime change is limited to classification based on the final exported DOM; it does not change capture selection or geometry acceptance. Source relationship: existing layout-geometry proof pipeline. Change kind: additive export metadata. Verification capability: focused test and diff checks. Evidence boundary: only accepted reductions targeting `img` or `picture` inside an `article` receive the image-well label.
Evidence
npm test -- src/lib/screenshot/layout-geometry-proof.test.ts: status=succeeded; candidate commit5d13ad731b293dd926600a6acb38a8f830673841, tree9c2b5ae6e57bc829b4a8414c30efb2ed95f83fc3, fingerprint73b99c294dca7c750588871dc8be7f1c1603708cf33d46587838aa7583b0a78c; durable gategate-1AI assistance