chore(fast-inbox): circuits cleanup and checkpoint header format (A-1387)#24792
Open
spalladino wants to merge 5 commits into
Open
chore(fast-inbox): circuits cleanup and checkpoint header format (A-1387)#24792spalladino wants to merge 5 commits into
spalladino wants to merge 5 commits into
Conversation
spalladino
force-pushed
the
spl/a-1386-l1-cleanup
branch
from
July 19, 2026 01:25
86a8360 to
a7eb238
Compare
spalladino
force-pushed
the
spl/a-1387-circuits-cleanup
branch
from
July 19, 2026 01:25
d06eb0f to
7e1dc3d
Compare
spalladino
force-pushed
the
spl/a-1386-l1-cleanup
branch
from
July 19, 2026 14:05
a7eb238 to
721cb08
Compare
spalladino
force-pushed
the
spl/a-1387-circuits-cleanup
branch
from
July 19, 2026 14:05
7e1dc3d to
0e1e0ed
Compare
spalladino
force-pushed
the
spl/a-1386-l1-cleanup
branch
from
July 19, 2026 15:10
721cb08 to
f09a847
Compare
spalladino
force-pushed
the
spl/a-1387-circuits-cleanup
branch
2 times, most recently
from
July 19, 2026 15:36
2277ca8 to
43ac45a
Compare
spalladino
force-pushed
the
spl/a-1386-l1-cleanup
branch
from
July 19, 2026 15:36
f09a847 to
8fa5988
Compare
spalladino
force-pushed
the
spl/a-1387-circuits-cleanup
branch
2 times, most recently
from
July 19, 2026 18:02
b82f5cc to
8287158
Compare
…uits (A-1387) Remove the dead unconstrained in_hash pass-through from InboxParity and ParityPublicInputs, and remove in_hash from the CheckpointHeader consensus format (struct, to_be_bytes, serialization length, Empty, hash fixtures). The Inbox rolling hash is now the checkpoint's only inbox commitment. Retire NUMBER_OF_L1_L2_MESSAGES_PER_ROLLUP in favor of MAX_L1_TO_L2_MSGS_PER_CHECKPOINT, and drop the now-unused L1_TO_L2_MSG_SUBTREE_ROOT_SIBLING_PATH_LENGTH and the NUM_MSGS_PER_BASE_PARITY / NUM_BASE_PARITY_PER_ROOT_PARITY frontier fan-in constants. Regenerated constants.gen.ts and ConstantsGen.sol via remake-constants.
…te FrontierLib (A-1387) Remove inHash from the ProposedHeader struct and its hash preimage in ProposedHeaderLib, keeping the packing byte-for-byte in lockstep with the noir and stdlib checkpoint headers. Update the decoder base struct and the propose test helpers, and regenerate the checkpoint fixtures (drop header.inHash, recompute headerHash). Delete FrontierLib and its only remaining users: the parity cross-check test (Parity.t.sol, which verified the deleted parity circuits) and the frontier merkle test/harness. The frontier tree is gone from both circuits and L1.
…h stdlib and node (A-1387) Mirror the consensus-format change in the stdlib CheckpointHeader (struct, serialization, viem, hash fixtures) and the circuit-ABI stdlib types (ParityPublicInputs, InboxParityPrivateInputs) and their noir conversion mappings. Sweep the header-inHash populate/read sites: the lightweight checkpoint builder, the checkpoint-proving orchestrator, the sequencer fixture writer, and the checkpoint proposal (its block-level inHash now sources zero rather than the removed header field). Regenerate the checkpoint p2p wire fixture for the shorter header. Replace NUMBER_OF_L1_L2_MESSAGES_PER_ROLLUP with MAX_L1_TO_L2_MSGS_PER_CHECKPOINT across the TS consumers. The block-level inHash struct fields (BlockProposal, L2Block) and stdlib/src/messaging/in_hash.ts remain for the node cleanup issue.
…oval (A-1387) The propose-failure test asserted the deleted Rollup__InvalidInHash selector (0xcd6f4233). With the legacy inHash L1 check gone, a checkpoint carrying messages that do not match the Inbox now reverts at validateInboxConsumption with Rollup__InvalidInboxRollingHash (0xed1f7bb5).
… checkpoint header (A-1387) Dropping inHash from the checkpoint header changes the checkpoint hash preimage, so the checkpoint ids the tips store persists change value. The stored format is unchanged (read-defaultable), so only the snapshot is regenerated; no PXE_DATA_SCHEMA_VERSION bump.
spalladino
force-pushed
the
spl/a-1387-circuits-cleanup
branch
from
July 19, 2026 20:30
8287158 to
4c4c1a8
Compare
spalladino
force-pushed
the
spl/a-1386-l1-cleanup
branch
from
July 19, 2026 20:30
225d2e7 to
3eb6939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FI-17 of the Fast Inbox (AZIP-22) stack. Stacked on #24791 (A-1386); it removes the legacy
inHashfrom the checkpoint header now that the consensus flip (#24789, A-1384) has switched validation to the streaming rolling hash. After this PR,inboxRollingHashis the checkpoint's only inbox commitment.Consensus-format change
inHashfield across all three preimage layers in lockstep: noirCheckpointHeader(checkpoint_header.nr), TSCheckpointHeader(stdlib/src/rollup/checkpoint_header.ts), and SolidityProposedHeaderLib(struct + hash packing). The field ordering is otherwise unchanged; the header shrinks by one field (32 bytes:CHECKPOINT_HEADER_SIZE_IN_BYTES380 to 348,CHECKPOINT_HEADER_LENGTH14 to 13).checkpoint_header.test.ts(the established workflow) and pasted into the noir tests; the p2p golden-byte fixture (wire_compat_fixtures.ts) was refreshed for the checkpoint-proposal serialization, which shrinks by exactly the one removed field. The block-proposal wire fixture is unchanged (block-levelinHashis out of scope, see A-1388).Circuits and constants
in_hashpass-through from the sizedInboxParity<S>circuit andParityPublicInputs(noir + TS + the hand-writtennoir-protocol-circuits-typesconversion wrappers). The circuit is kept (sized-parity, per FI-06's topology decision), so no VK-tree indices move.NUMBER_OF_L1_L2_MESSAGES_PER_ROLLUP(replaced everywhere byMAX_L1_TO_L2_MSGS_PER_CHECKPOINT, same value 1024) and the now-deadNUM_MSGS_PER_BASE_PARITY,NUM_BASE_PARITY_PER_ROOT_PARITY, andL1_TO_L2_MSG_SUBTREE_ROOT_SIBLING_PATH_LENGTH. Generated constants (constants.gen.ts,ConstantsGen.sol) were regenerated viaremake-constants.FrontierLib.soland its tests (Parity.t.sol, theFrontierharness and merkle test) now that their last users are gone.Verification
types::checkpoint_header(5/5),rollup_lib::parityandcheckpoint_root::parity_tests(15/15), and the checkpoint-root header-assembly path pass locally. The fullcheckpoint_rootsuite (68 tests) is too slow to run in full locally and rides CI.forge testgreen acrossRollup,RollupFieldRange,Inbox,InboxBuckets,RollupGetters(76/76), covering header hashing and the regenerated checkpoint fixtures.checkpoint_header, the p2p wire-compat suites, and the parity/messaging suites pass (43 tests), confirming the fixture regeneration is byte-consistent.yarn buildinnoir-protocol-circuits-types/simulator/prover-clientis expected to fail on stale circuit artifacts until then); e2e and the broken-zone typecheck are the CI-of-record for those.Stack
Part of the Fast Inbox stack #24784 through #24791 (umbrella #24774): A-1379 (#24784), A-1380 (#24785), A-1381 (#24786), A-1382 (#24787), A-1383 (#24788), A-1384 flip (#24789), A-1385 (#24790), A-1386 (#24791, base of this PR).
Resolves A-1387.