chore(fast-inbox): emit inbox lag and checkpoint cap from the constants generator (A-1434)#24794
Open
spalladino wants to merge 2 commits into
Open
chore(fast-inbox): emit inbox lag and checkpoint cap from the constants generator (A-1434)#24794spalladino wants to merge 2 commits into
spalladino wants to merge 2 commits into
Conversation
spalladino
force-pushed
the
spl/a-1388-node-cleanup
branch
from
July 19, 2026 01:25
92cecbd to
83a74e1
Compare
spalladino
force-pushed
the
spl/a-1434-inbox-constants-gen
branch
from
July 19, 2026 01:25
57e98bd to
beda331
Compare
spalladino
force-pushed
the
spl/a-1434-inbox-constants-gen
branch
from
July 19, 2026 14:05
beda331 to
c49ff84
Compare
spalladino
force-pushed
the
spl/a-1388-node-cleanup
branch
from
July 19, 2026 15:10
115b351 to
5817030
Compare
spalladino
force-pushed
the
spl/a-1434-inbox-constants-gen
branch
2 times, most recently
from
July 19, 2026 15:36
eaae5fb to
2d2d3cf
Compare
spalladino
force-pushed
the
spl/a-1388-node-cleanup
branch
from
July 19, 2026 15:36
5817030 to
01b921a
Compare
spalladino
force-pushed
the
spl/a-1434-inbox-constants-gen
branch
from
July 19, 2026 17:57
2d2d3cf to
a63553a
Compare
spalladino
force-pushed
the
spl/a-1388-node-cleanup
branch
from
July 19, 2026 17:57
01b921a to
6269f44
Compare
spalladino
force-pushed
the
spl/a-1434-inbox-constants-gen
branch
from
July 19, 2026 18:02
a63553a to
17bdffa
Compare
spalladino
force-pushed
the
spl/a-1388-node-cleanup
branch
from
July 19, 2026 18:02
6269f44 to
3111d18
Compare
spalladino
force-pushed
the
spl/a-1434-inbox-constants-gen
branch
2 times, most recently
from
July 19, 2026 20:30
9d89bdc to
b6660d3
Compare
spalladino
force-pushed
the
spl/a-1388-node-cleanup
branch
2 times, most recently
from
July 19, 2026 20:48
5660774 to
7fa4b0a
Compare
spalladino
force-pushed
the
spl/a-1434-inbox-constants-gen
branch
from
July 19, 2026 20:48
b6660d3 to
05ce596
Compare
…ts generator (A-1434) Add INBOX_LAG_SECONDS and MAX_L1_TO_L2_MSGS_PER_CHECKPOINT to the Solidity constants allowlist so the generator emits them into ConstantsGen.sol, matching the values already present in constants.gen.ts. ProposeLib and its consumption test now read the generated Constants library instead of the hand-declared file-scope copies, giving L1 and TS a single source of truth.
spalladino
force-pushed
the
spl/a-1434-inbox-constants-gen
branch
from
July 19, 2026 20:51
05ce596 to
ab7ddb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
INBOX_LAG_SECONDS(12) andMAX_L1_TO_L2_MSGS_PER_CHECKPOINT(1024) out of the hand-declared file-scope constants inProposeLib.soland into the generatedConstantslibrary, giving L1 Solidity and the TS node a single source of truth (A-1434, Fast Inbox cleanup).Both values already lived in
constants.nr(the Noir source of truth) and were already emitted toconstants.gen.ts; the only gap was the Solidity side, which gates emission behind an allowlist.SOLIDITY_CONSTANTSallowlist inconstants/src/scripts/constants.in.ts, soyarn remake-constantsemits them intoConstantsGen.sol.constants.gen.tsis unchanged (already present).ConstantsGen.sol(generator output; not hand-edited).ProposeLib.solimportsConstantsand references the generated values; the hand-declared file-scope copies are deleted.ProposeInboxConsumption.t.solto import the constants fromConstantsGen.solinstead ofProposeLib.sol.TS node code that validates inbox consumption (
stdlibcutoff predicate,validator-clientstreaming checks,sequencer-clientbucket selector) already reads these from@aztec/constants, so no TS source change is needed.Testing:
forge buildandforge test test/rollup/ProposeInboxConsumption.t.sol(15 tests) pass.stdlibinbox_consumption (10),validator-clientstreaming_inbox_checks (14),sequencer-clientinbox_bucket_selector (9).@aztec/constants,@aztec/l1-artifacts, and@aztec/ethereumbuild.Part of the Fast Inbox stack, on top of #24784..#24793.