Repository navigation
Jonachang/e2einternal - #5134
Open
Jonathan CHang (jonathan34c) wants to merge 2 commits into
Open
Jonathan CHang (jonathan34c) wants to merge 2 commits into
Jonathan CHang (jonathan34c) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jonathan CHang (jonathan34c)
requested review from
Caden Marchese (cadenmarchese),
cloudygreybeard,
Amber Brown (hawkowl),
Hilliary Lipsig (hlipsig),
Kevin O'Brien (kevinobriendotca),
Kipp Morris (kimorris27),
Marius Schulz (mrWinston),
Jose Gavine Cueto (pepedocs),
Rogerio Bastos (rogbas),
Ankur Singh (sankur-codes),
Miguel Abad Perez (tiguelu),
Tanmay Satam (tsatam),
Andrew Denton (ventifus),
Haoran Wang (wanghaoran1988) and
Jeff Yuan (yjst2012)
as code owners
October 7, 2026 18:51
Copilot started reviewing on behalf of
Jonathan CHang (jonathan34c)
October 7, 2026 18:52
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The credential paths are consistently applied while preserving the existing fallback behavior.
0 open findings
What changed in this PR
Enables Classic E2E infrastructure to use Azure managed identity while retaining service-principal fallback.
Changes:
- Selects credentials using
AZURE_TOKEN_CREDENTIALS. - Conditionally validates service-principal variables.
- Reuses credential selection across E2E Azure clients.
| File | Description |
|---|---|
test/e2e/setup.go |
Adds flexible E2E credential selection and validation. |
pkg/util/cluster/cluster.go |
Supports selected Azure credentials for cluster operations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tanmay Satam (tsatam)
approved these changes
Oct 7, 2026
Adam Price (komidore64)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Supersedes/follows up #5100.
Allows Classic E2E tests to authenticate with a managed identity when
AZURE_TOKEN_CREDENTIALS is set, while preserving service-principal
authentication for existing environments.
Validation:
go test ./test/e2e -run '^$'
What this PR does / why we need it:
Supersedes/follows up #5100.
Allows Classic E2E tests to authenticate with a managed identity when
AZURE_TOKEN_CREDENTIALS is set, while preserving service-principal
authentication for existing environments.
Validation:
go test ./test/e2e -run '^$'
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?