fix: fix AKS issue 5909 - #9308
Open
Peter Damianov (pdamianov-dev) wants to merge 2 commits into
Open
Conversation
Peter Damianov (pdamianov-dev)
requested review from
Chou Hu (AbelHu),
Devinwong,
Sri Harsha (SriHarsha001),
Abigail Liang (abigailliang-aks-sig-node),
Abdul Asfari (aboodasfari),
Nishchay (awesomenix),
Ben Brady (benjamin-brady),
Calvin S. (calvin197),
Cameron Meissner (cameronmeissner),
Sylvain Boily (djsly),
fcher,
Ganeshkumar Ashokavardhanan (ganeshkumarashok),
janenotjung-hue,
Karen Chen (karenychen),
lilypan26,
Mark Ibrahim (mxj220),
Patrick W. Healy (phealy),
r2k1,
Runzhen (runzhen),
Shun Lyu (sinmentis),
sulixu,
Tim Wright (timmy-wright),
Thibault Cohen (titilambert),
Xu Xue (xuexu6666) and
Zachary (zachary-bailey)
as code owners
August 25, 2026 22:27
Copilot started reviewing on behalf of
Peter Damianov (pdamianov-dev)
August 25, 2026 22:28
View session
Contributor
Windows Unit Test Results 3 files 13 suites 41s ⏱️ Results for commit b5a86e0. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates containerd 2 configuration templates to schema version 3 so split CRI plugin paths are recognized.
Changes:
- Changes containerd 2 templates from schema v2 to v3.
- Updates parser expectations and detection tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/agent/baker.go |
Updates AgentBaker containerd 2 templates. |
aks-node-controller/parser/templates/containerd_v2.toml.gtpl |
Updates the GPU-capable template schema. |
aks-node-controller/parser/templates/containerd_v2_no_GPU.toml.gtpl |
Updates the no-GPU template schema. |
aks-node-controller/parser/parser_test.go |
Verifies selected schema versions. |
aks-node-controller/parser/helper_test.go |
Updates rendered configuration expectations. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Peter Damianov (pdamianov-dev)
August 25, 2026 22:44
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Azure/AKS#5909
Which issue(s) this PR fixes: Azure/AKS#5909
Fixes #