chore(deps): add 2604 acr-mirror ref - #9309
Open
Peter Damianov (pdamianov-dev) wants to merge 2 commits into
Open
chore(deps): add 2604 acr-mirror ref#9309Peter Damianov (pdamianov-dev) wants to merge 2 commits into
Peter Damianov (pdamianov-dev) wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
components
Copilot started reviewing on behalf of
Peter Damianov (pdamianov-dev)
August 25, 2026 23:20
View session
Contributor
Windows Unit Test Results 3 files 13 suites 45s ⏱️ Results for commit a0437b0. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds acr-mirror 1.0.0 support for Ubuntu 26.04 VHDs, enabling artifact streaming.
Changes:
- Adds Ubuntu 26.04 package metadata and download URL.
- Keeps acr-mirror pinned against Renovate updates.
Package Update Analysis: acr-mirror
Version change: Unsupported → 1.0.0 (new OS enablement)
OS affected: Ubuntu 26.04 amd64 and arm64
Risk: 🟡 Medium — upstream changelog and artifact URLs could not be independently verified, and Ubuntu 26.04 lacks artifact-streaming E2E coverage.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Peter Damianov (pdamianov-dev)
requested review from
Devinwong,
Sri Harsha (SriHarsha001),
Abdul Asfari (aboodasfari),
Nishchay (awesomenix),
Ben Brady (benjamin-brady),
Calvin S. (calvin197),
Cameron Meissner (cameronmeissner),
Sylvain Boily (djsly),
fcher,
Ganeshkumar Ashokavardhanan (ganeshkumarashok),
Karen Chen (karenychen),
lilypan26,
Mark Ibrahim (mxj220),
Patrick W. Healy (phealy),
r2k1,
Runzhen (runzhen),
Shun Lyu (sinmentis),
sulixu,
Tim Wright (timmy-wright),
Thibault Cohen (titilambert),
Xu Xue (xuexu6666) and
Zachary (zachary-bailey)
as code owners
August 26, 2026 23:33
Peter Damianov (pdamianov-dev)
requested review from
Abigail Liang (abigailliang-aks-sig-node) and
janenotjung-hue
as code owners
August 26, 2026 23:33
Copilot started reviewing on behalf of
Peter Damianov (pdamianov-dev)
August 26, 2026 23:33
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
e2e/scenario_test.go:1273
- 🟡 Medium Risk — 🧪 Test Coverage: The ARM64 package is fetched from a distinct derived URL (
acr-mirror-2604-arm64.deb), but this validation only checks that its services remain running. A broken ARM64 streaming path can still fall back silently to overlayfs and pass. ExerciseValidateArtifactStreamingImagePullon Ubuntu 26.04 ARM64 (using a compatible anonymous Premium ACR cluster) to validate the architecture-specific artifact end to end.
Validator: func(ctx context.Context, s *Scenario) error {
return errors.Join(
ValidateNonEmptyDirectory(ctx, s, "/etc/overlaybd"),
ValidateSystemdUnitIsRunning(ctx, s, "overlaybd-snapshotter.service"),
ValidateSystemdUnitIsRunning(ctx, s, "overlaybd-tcmu.service"),
ValidateSystemdUnitIsRunning(ctx, s, "acr-mirror.service"),
ValidateSystemdUnitIsRunning(ctx, s, "containerd.service"),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: chore(deps): add 2604 acr-mirror ref for artifact streaming support on 2604
Which issue(s) this PR fixes: chore(deps): add 2604 acr-mirror ref
Fixes #