Skip to content

[AKS] az aks nodepool add dra option - #10268

Merged
Julie Zhu (yanzhudd) merged 5 commits into
Azure:mainfrom
runzhen:dra2
Sep 1, 2026
Merged

Julie Zhu (yanzhudd) merged 5 commits into
Azure:mainfrom
runzhen:dra2

Conversation

@runzhen

@runzhen Runzhen (runzhen) commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ❌ Action needed

Breaking Changes
❌ 1
❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter managed_gpu_driver_mode
⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter managed_gpu_driver_mode

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks nodepool add
az aks nodepool update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI lite review requested due to automatic review settings August 27, 2026 22:26
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Runzhen (@runzhen),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the aks-preview extension for selecting the Managed GPU driver mode when enabling Managed GPU on an AKS nodepool, and updates docs/tests accordingly.

Changes:

  • Introduces --managed-gpu-driver-mode for az aks nodepool add / az aks nodepool update (enum: DRA, DevicePlugin) and wires it into the agentpool GPU profile.
  • Updates help text and HISTORY entry to document the new option and default behavior.
  • Extends scenario/unit tests to validate default driver mode and explicit DRA selection.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/aks-preview/HISTORY.rst Documents the new --managed-gpu-driver-mode option in release notes.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Adds scenario checks for returned gpuProfile.nvidia.driverMode.
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py Adds unit coverage for default driver mode and validation behavior.
src/aks-preview/azext_aks_preview/custom.py Adds managed_gpu_driver_mode to nodepool add/update custom command signatures for plumbing via locals().
src/aks-preview/azext_aks_preview/agentpool_decorator.py Implements driver mode defaulting/validation and sets nvidia.driver_mode on the model.
src/aks-preview/azext_aks_preview/_params.py Registers the new CLI argument for nodepool add/update.
src/aks-preview/azext_aks_preview/_help.py Documents the option, default, and requirement in command help.
src/aks-preview/azext_aks_preview/_consts.py Adds constants for the driver mode enum values.
Suppressed comments (1)

src/aks-preview/azext_aks_preview/_params.py:2601

  • The argument help for managed_gpu_driver_mode (nodepool update) doesn’t mention the default (DevicePlugin) or that it requires --enable-managed-gpu=true, even though the command help text and runtime validation do. Aligning these avoids user confusion in az ... -h.
            arg_type=get_enum_type(managed_gpu_driver_modes),
            is_preview=True,
            help="Specify the Managed GPU driver mode. Allowed values: DRA, DevicePlugin.",
        )

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/aks-preview/azext_aks_preview/agentpool_decorator.py
Comment thread src/aks-preview/azext_aks_preview/_params.py
Runzhen (runzhen) and others added 2 commits August 27, 2026 15:50
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@yonzhan

Copy link
Copy Markdown
Collaborator

AKS

Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
@yanzhudd
Julie Zhu (yanzhudd) merged commit 9581979 into Azure:main Sep 1, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants