[AKS] az aks nodepool add dra option - #10268
Merged
Merged
Conversation
|
Hi Runzhen (@runzhen), |
microsoft-github-policy-service
Bot
requested review from
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
August 27, 2026 22:26
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the aks-preview extension for selecting the Managed GPU driver mode when enabling Managed GPU on an AKS nodepool, and updates docs/tests accordingly.
Changes:
- Introduces
--managed-gpu-driver-modeforaz aks nodepool add/az aks nodepool update(enum:DRA,DevicePlugin) and wires it into the agentpool GPU profile. - Updates help text and HISTORY entry to document the new option and default behavior.
- Extends scenario/unit tests to validate default driver mode and explicit
DRAselection.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/HISTORY.rst | Documents the new --managed-gpu-driver-mode option in release notes. |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Adds scenario checks for returned gpuProfile.nvidia.driverMode. |
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py | Adds unit coverage for default driver mode and validation behavior. |
| src/aks-preview/azext_aks_preview/custom.py | Adds managed_gpu_driver_mode to nodepool add/update custom command signatures for plumbing via locals(). |
| src/aks-preview/azext_aks_preview/agentpool_decorator.py | Implements driver mode defaulting/validation and sets nvidia.driver_mode on the model. |
| src/aks-preview/azext_aks_preview/_params.py | Registers the new CLI argument for nodepool add/update. |
| src/aks-preview/azext_aks_preview/_help.py | Documents the option, default, and requirement in command help. |
| src/aks-preview/azext_aks_preview/_consts.py | Adds constants for the driver mode enum values. |
Suppressed comments (1)
src/aks-preview/azext_aks_preview/_params.py:2601
- The argument help for managed_gpu_driver_mode (nodepool update) doesn’t mention the default (DevicePlugin) or that it requires --enable-managed-gpu=true, even though the command help text and runtime validation do. Aligning these avoids user confusion in
az ... -h.
arg_type=get_enum_type(managed_gpu_driver_modes),
is_preview=True,
help="Specify the Managed GPU driver mode. Allowed values: DRA, DevicePlugin.",
)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
AKS |
FumingZhang
approved these changes
Aug 31, 2026
FumingZhang
reviewed
Aug 31, 2026
Julie Zhu (yanzhudd)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ❌ Action needed
❌Azure CLI Extensions Breaking Change Test
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks nodepool add
az aks nodepool update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.