Repository navigation
{AKS} aimanager validator refactor - #10269
Julie Zhu (yanzhudd) merged 2 commits into
Conversation
|
Hi Ximeng Zhao (@xmzhao0822), |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Refactors the AI Manager extension’s name validators to reduce duplication and make validation behavior consistent, along with the corresponding pre-release version bump and changelog entry.
Changes:
- Bumped the
aimanagerextension version to1.5.2b1. - Added a
1.5.2b1entry toHISTORY.rst. - Refactored repeated “blank name” validation logic in
azext_aimanager/_validators.pyinto a shared helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/aimanager/setup.py |
Updates extension package version to 1.5.2b1. |
src/aimanager/HISTORY.rst |
Adds release notes for 1.5.2b1 reflecting the validator refactor. |
src/aimanager/azext_aimanager/_validators.py |
Introduces _validate_name helper and reuses it across name validators. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
AKS |
|
[Release] Update index.json for extension [ aimanager-1.5.2b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=178618516&view=results |
🤖 PR Validation — ️✔️ All clear
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Refactors src/aimanager/azext_aimanager/_validators.py to make the name validators consistent and DRY.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.