Skip to content

{AKS} aimanager validator refactor - #10269

Merged
Julie Zhu (yanzhudd) merged 2 commits into
Azure:mainfrom
xmzhao0822:xmzhao/refactor-aimanager-validator
Aug 28, 2026
Merged

Julie Zhu (yanzhudd) merged 2 commits into
Azure:mainfrom
xmzhao0822:xmzhao/refactor-aimanager-validator

Conversation

@xmzhao0822

@xmzhao0822 Ximeng Zhao (xmzhao0822) commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ️✔️ All clear

Breaking Changes
️✔️ None

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Refactors src/aimanager/azext_aimanager/_validators.py to make the name validators consistent and DRY.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI lite review requested due to automatic review settings August 28, 2026 00:31
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Ximeng Zhao (@xmzhao0822),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the AI Manager extension’s name validators to reduce duplication and make validation behavior consistent, along with the corresponding pre-release version bump and changelog entry.

Changes:

  • Bumped the aimanager extension version to 1.5.2b1.
  • Added a 1.5.2b1 entry to HISTORY.rst.
  • Refactored repeated “blank name” validation logic in azext_aimanager/_validators.py into a shared helper.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/aimanager/setup.py Updates extension package version to 1.5.2b1.
src/aimanager/HISTORY.rst Adds release notes for 1.5.2b1 reflecting the validator refactor.
src/aimanager/azext_aimanager/_validators.py Introduces _validate_name helper and reuses it across name validators.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/aimanager/azext_aimanager/_validators.py Outdated
Comment thread src/aimanager/azext_aimanager/_validators.py
Comment thread src/aimanager/azext_aimanager/_validators.py
@yonzhan

Copy link
Copy Markdown
Collaborator

AKS

@yanzhudd
Julie Zhu (yanzhudd) merged commit a9cda72 into Azure:main Aug 28, 2026
24 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ aimanager-1.5.2b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=178618516&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act-observability-squad AKS Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants