Skip to content

authV2: remove AZURE_GERMAN_CLOUD from cloud options - #10293

Closed
Yeming Liu (isra-fel) with Copilot wants to merge 1 commit into
mainfrom
copilot/remove-azure-german-cloud-references
Closed

Yeming Liu (isra-fel) with Copilot wants to merge 1 commit into
mainfrom
copilot/remove-azure-german-cloud-references

Conversation

Copilot AI commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ️✔️ All clear

Breaking Changes
️✔️ None

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • az webapp auth

  • az webapp auth update

  • Problem

    • authV2 still referenced AZURE_GERMAN_CLOUD in allowed cloud names; this retired cloud should not be exposed in parameter choices.
  • Changes

    • Parameter surface: removed AZURE_GERMAN_CLOUD import and removed it from CLOUD_NAMES in src/authV2/azext_authV2/_params.py.
    • Versioning: bumped src/authV2/setup.py from 1.0.1 to 1.0.2.
    • History: added a 1.0.2 entry in src/authV2/HISTORY.rst for this change.
  • Code snippet

# before
CLOUD_NAMES = [AZURE_PUBLIC_CLOUD.name, AZURE_CHINA_CLOUD.name, AZURE_US_GOV_CLOUD.name, AZURE_GERMAN_CLOUD.name]

# after
CLOUD_NAMES = [AZURE_PUBLIC_CLOUD.name, AZURE_CHINA_CLOUD.name, AZURE_US_GOV_CLOUD.name]

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
This PR updates setup.py and HISTORY.rst accordingly and does not modify src/index.json.

Co-authored-by: isra-fel <11371776+isra-fel@users.noreply.github.com>
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Copilot,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped, consistent with the PR description, and leaves no remaining AZURE_GERMAN_CLOUD references in the extension code.

Pull request overview

This PR updates the authV2 extension to stop exposing the retired AZURE_GERMAN_CLOUD as an allowed cloud name for az webapp auth / az webapp auth update, and bumps the extension version accordingly.

Changes:

  • Removed AZURE_GERMAN_CLOUD from the azure.cli.core.cloud import list and from CLOUD_NAMES in azext_authV2/_params.py.
  • Bumped the extension version from 1.0.1 to 1.0.2 in setup.py.
  • Added a 1.0.2 entry to HISTORY.rst documenting the change.
File summaries
File Description
src/authV2/azext_authV2/_params.py Removes the retired German cloud from the allowed cloud-name choices.
src/authV2/setup.py Version bump to publish the parameter-surface change.
src/authV2/HISTORY.rst Changelog entry documenting the removed cloud option.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@isra-fel

Copy link
Copy Markdown
Member

Superseded by #10294, which contains identical changes submitted from a forked repository/branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants