authV2: remove AZURE_GERMAN_CLOUD from cloud options - #10293
Yeming Liu (isra-fel) with Copilot wants to merge 1 commit into
Conversation
Co-authored-by: isra-fel <11371776+isra-fel@users.noreply.github.com>
|
Hi Copilot, |
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, consistent with the PR description, and leaves no remaining AZURE_GERMAN_CLOUD references in the extension code.
Pull request overview
This PR updates the authV2 extension to stop exposing the retired AZURE_GERMAN_CLOUD as an allowed cloud name for az webapp auth / az webapp auth update, and bumps the extension version accordingly.
Changes:
- Removed
AZURE_GERMAN_CLOUDfrom theazure.cli.core.cloudimport list and fromCLOUD_NAMESinazext_authV2/_params.py. - Bumped the extension version from
1.0.1to1.0.2insetup.py. - Added a
1.0.2entry toHISTORY.rstdocumenting the change.
File summaries
| File | Description |
|---|---|
| src/authV2/azext_authV2/_params.py | Removes the retired German cloud from the allowed cloud-name choices. |
| src/authV2/setup.py | Version bump to publish the parameter-surface change. |
| src/authV2/HISTORY.rst | Changelog entry documenting the removed cloud option. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Superseded by #10294, which contains identical changes submitted from a forked repository/branch. |
🤖 PR Validation — ️✔️ All clear
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az webapp authaz webapp auth updateProblem
AZURE_GERMAN_CLOUDin allowed cloud names; this retired cloud should not be exposed in parameter choices.Changes
AZURE_GERMAN_CLOUDimport and removed it fromCLOUD_NAMESinsrc/authV2/azext_authV2/_params.py.src/authV2/setup.pyfrom1.0.1to1.0.2.1.0.2entry insrc/authV2/HISTORY.rstfor this change.Code snippet
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.This PR updates
setup.pyandHISTORY.rstaccordingly and does not modifysrc/index.json.