[aks-preview] Fix managed GPU autoscaler configuration updates - #10343
Merged
Julie Zhu (yanzhudd) merged 3 commits intoSep 17, 2026
Merged
Julie Zhu (yanzhudd) merged 3 commits into
Julie Zhu (yanzhudd) merged 3 commits into
Conversation
Keep omitted --enable-managed-gpu distinct from explicit false so autoscaler and metadata updates do not mutate the immutable GPU profile. Add handler and parser regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ganeshkumar Ashokavardhanan (ganeshkumarashok)
requested a review
from FumingZhang
as a code owner
September 15, 2026 23:35
|
Hi Ganeshkumar Ashokavardhanan (@ganeshkumarashok), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 15, 2026 23:36
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are covered by regression tests and no unresolved blocking issues remain.
Pull request overview
Fixes az aks nodepool update so omitted --enable-managed-gpu preserves the existing GPU profile.
Changes:
- Uses
Noneas the update-only default. - Adds regression and parser tests.
- Documents the fix in release notes.
File summaries
| File | Description |
|---|---|
src/aks-preview/HISTORY.rst |
Adds the release note. |
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_update.py |
Adds regression and parser coverage. |
src/aks-preview/azext_aks_preview/custom.py |
Preserves omitted managed-GPU settings during updates. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
FumingZhang
previously approved these changes
Sep 16, 2026
Member
|
/azp run |
FumingZhang
approved these changes
Sep 17, 2026
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Julie Zhu (yanzhudd)
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az aks nodepool updateDescription
Preserve the existing GPU management mode when
--enable-managed-gpuis omitted.The update handler currently defaults this three-state option to
False. The managed-GPU decorator correctly treatsNoneas "leave unchanged" andFalseas "set Unmanaged", so an unrelated update silently changes an existing managed GPU pool to Unmanaged in the outgoing request. Because the GPU management mode is immutable, the service rejects the request with:This includes enabling, changing the bounds of, or disabling Cluster Autoscaler, as well as updating labels or tags.
Change the update-only default to
None. Explicit true/false inputs and node-pool creation defaults remain unchanged. This does not relax service-side GPU-profile immutability.Validation
ManagedtoUnmanaged.None; bare option or explicit true ->True; explicit false ->False.Scope
This fixes unintended GPU-profile mutation in the CLI configuration path. Preservation of existing MIG/DRA fields is not a claim that those configurations support every autoscaling scenario. This PR does not change the published managed-GPU support policy, GPU resource discovery, scale-from-zero behavior, or upstream autoscaler implementation.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)The release note is in
HISTORY.rst's Pending section, following that file's guidance. No version or extension index changes are included.